Check presentation support in isDeviceSuitable - #474
Merged
gpx1000 merged 2 commits intoSep 3, 2026
Conversation
asuessenbach
approved these changes
Aug 24, 2026
SaschaWillems
approved these changes
Sep 3, 2026
SaschaWillems
left a comment
SaschaWillems
left a comment
Collaborator
There was a problem hiding this comment.
Even though I don't like that syntax style at all, it works as expected. So I'm fine with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isDeviceSuitable() only checked for a graphics-capable queue family, but createLogicalDevice() later requires one that supports both graphics and presentation. A device could pass suitability and then throw in createLogicalDevice(). Extends the existing search to also require getSurfaceSupportKHR(qfpIndex, *surface), applied consistently across every chapter from window-surface creation onward.
Fixes #457.