Skip to content

Check presentation support in isDeviceSuitable #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpx1000 merged 2 commits into from
Sep 3, 2026
Merged

Check presentation support in isDeviceSuitable #474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a66936d
Check presentation support in isDeviceSuitable across all chapters
gpx1000 Aug 20, 2026
0e39e55
Carry the any_of presentation-support refactor to all chapters
gpx1000 Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions attachments/05_window_surface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,9 +166,16 @@ class HelloTriangleApplication
// Check if the physicalDevice supports the Vulkan 1.3 API version
bool supportsVulkan1_3 = physicalDevice.getProperties().apiVersion >= VK_API_VERSION_1_3;

// Check if any of the queue families support graphics operations
auto queueFamilies = physicalDevice.getQueueFamilyProperties();
bool supportsGraphics = std::ranges::any_of(queueFamilies, [](auto const &qfp) { return !!(qfp.queueFlags & vk::QueueFlagBits::eGraphics); });
// Check if any of the queue families support both graphics and presentation to our surface
auto queueFamilies = physicalDevice.getQueueFamilyProperties();
uint32_t qfpIndex = 0;
bool supportsGraphicsAndPresent =
std::ranges::any_of(queueFamilies,
[&physicalDevice, &surface = this->surface, &qfpIndex](auto const &qfp) {
bool const suitable = (qfp.queueFlags & vk::QueueFlagBits::eGraphics) && physicalDevice.getSurfaceSupportKHR(qfpIndex, *surface);
qfpIndex++;
return suitable;
});

// Check if all required physicalDevice extensions are available
auto availableDeviceExtensions = physicalDevice.enumerateDeviceExtensionProperties();
Expand All @@ -189,7 +196,7 @@ class HelloTriangleApplication
features.template get<vk::PhysicalDeviceExtendedDynamicStateFeaturesEXT>().extendedDynamicState;

// Return true if the physicalDevice meets all the criteria
return supportsVulkan1_3 && supportsGraphics && supportsAllRequiredExtensions && supportsRequiredFeatures;
return supportsVulkan1_3 && supportsGraphicsAndPresent && supportsAllRequiredExtensions && supportsRequiredFeatures;
}

void pickPhysicalDevice()
Expand Down
15 changes: 11 additions & 4 deletions attachments/06_swap_chain_creation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,9 +174,16 @@ class HelloTriangleApplication
// Check if the physicalDevice supports the Vulkan 1.3 API version
bool supportsVulkan1_3 = physicalDevice.getProperties().apiVersion >= VK_API_VERSION_1_3;

// Check if any of the queue families support graphics operations
auto queueFamilies = physicalDevice.getQueueFamilyProperties();
bool supportsGraphics = std::ranges::any_of(queueFamilies, [](auto const &qfp) { return !!(qfp.queueFlags & vk::QueueFlagBits::eGraphics); });
// Check if any of the queue families support both graphics and presentation to our surface
auto queueFamilies = physicalDevice.getQueueFamilyProperties();
uint32_t qfpIndex = 0;
bool supportsGraphicsAndPresent =
std::ranges::any_of(queueFamilies,
[&physicalDevice, &surface = this->surface, &qfpIndex](auto const &qfp) {
bool const suitable = (qfp.queueFlags & vk::QueueFlagBits::eGraphics) && physicalDevice.getSurfaceSupportKHR(qfpIndex, *surface);
qfpIndex++;
return suitable;
});

// Check if all required physicalDevice extensions are available
auto availableDeviceExtensions = physicalDevice.enumerateDeviceExtensionProperties();
Expand All @@ -197,7 +204,7 @@ class HelloTriangleApplication
features.template get<vk::PhysicalDeviceExtendedDynamicStateFeaturesEXT>().extendedDynamicState;

// Return true if the physicalDevice meets all the criteria
return supportsVulkan1_3 && supportsGraphics && supportsAllRequiredExtensions && supportsRequiredFeatures;
return supportsVulkan1_3 && supportsGraphicsAndPresent && supportsAllRequiredExtensions && supportsRequiredFeatures;
}

void pickPhysicalDevice()
Expand Down
15 changes: 11 additions & 4 deletions attachments/07_image_views.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,9 +175,16 @@ class HelloTriangleApplication
// Check if the physicalDevice supports the Vulkan 1.3 API version
bool supportsVulkan1_3 = physicalDevice.getProperties().apiVersion >= VK_API_VERSION_1_3;

// Check if any of the queue families support graphics operations
auto queueFamilies = physicalDevice.getQueueFamilyProperties();
bool supportsGraphics = std::ranges::any_of(queueFamilies, [](auto const &qfp) { return !!(qfp.queueFlags & vk::QueueFlagBits::eGraphics); });
// Check if any of the queue families support both graphics and presentation to our surface
auto queueFamilies = physicalDevice.getQueueFamilyProperties();
uint32_t qfpIndex = 0;
bool supportsGraphicsAndPresent =
std::ranges::any_of(queueFamilies,
[&physicalDevice, &surface = this->surface, &qfpIndex](auto const &qfp) {
bool const suitable = (qfp.queueFlags & vk::QueueFlagBits::eGraphics) && physicalDevice.getSurfaceSupportKHR(qfpIndex, *surface);
qfpIndex++;
return suitable;
});

// Check if all required physicalDevice extensions are available
auto availableDeviceExtensions = physicalDevice.enumerateDeviceExtensionProperties();
Expand All @@ -198,7 +205,7 @@ class HelloTriangleApplication
features.template get<vk::PhysicalDeviceExtendedDynamicStateFeaturesEXT>().extendedDynamicState;

// Return true if the physicalDevice meets all the criteria
return supportsVulkan1_3 && supportsGraphics && supportsAllRequiredExtensions && supportsRequiredFeatures;
return supportsVulkan1_3 && supportsGraphicsAndPresent && supportsAllRequiredExtensions && supportsRequiredFeatures;
}

void pickPhysicalDevice()
Expand Down
15 changes: 11 additions & 4 deletions attachments/08_graphics_pipeline.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,9 +176,16 @@ class HelloTriangleApplication
// Check if the physicalDevice supports the Vulkan 1.3 API version
bool supportsVulkan1_3 = physicalDevice.getProperties().apiVersion >= VK_API_VERSION_1_3;

// Check if any of the queue families support graphics operations
auto queueFamilies = physicalDevice.getQueueFamilyProperties();
bool supportsGraphics = std::ranges::any_of(queueFamilies, [](auto const &qfp) { return !!(qfp.queueFlags & vk::QueueFlagBits::eGraphics); });
// Check if any of the queue families support both graphics and presentation to our surface
auto queueFamilies = physicalDevice.getQueueFamilyProperties();
uint32_t qfpIndex = 0;
bool supportsGraphicsAndPresent =
std::ranges::any_of(queueFamilies,
[&physicalDevice, &surface = this->surface, &qfpIndex](auto const &qfp) {
bool const suitable = (qfp.queueFlags & vk::QueueFlagBits::eGraphics) && physicalDevice.getSurfaceSupportKHR(qfpIndex, *surface);
qfpIndex++;
return suitable;
});

// Check if all required physicalDevice extensions are available
auto availableDeviceExtensions = physicalDevice.enumerateDeviceExtensionProperties();
Expand All @@ -199,7 +206,7 @@ class HelloTriangleApplication
features.template get<vk::PhysicalDeviceExtendedDynamicStateFeaturesEXT>().extendedDynamicState;

// Return true if the physicalDevice meets all the criteria
return supportsVulkan1_3 && supportsGraphics && supportsAllRequiredExtensions && supportsRequiredFeatures;
return supportsVulkan1_3 && supportsGraphicsAndPresent && supportsAllRequiredExtensions && supportsRequiredFeatures;
}

void pickPhysicalDevice()
Expand Down
15 changes: 11 additions & 4 deletions attachments/09_shader_modules.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,16 @@ class HelloTriangleApplication
// Check if the physicalDevice supports the Vulkan 1.3 API version
bool supportsVulkan1_3 = physicalDevice.getProperties().apiVersion >= VK_API_VERSION_1_3;

// Check if any of the queue families support graphics operations
auto queueFamilies = physicalDevice.getQueueFamilyProperties();
bool supportsGraphics = std::ranges::any_of(queueFamilies, [](auto const &qfp) { return !!(qfp.queueFlags & vk::QueueFlagBits::eGraphics); });
// Check if any of the queue families support both graphics and presentation to our surface
auto queueFamilies = physicalDevice.getQueueFamilyProperties();
uint32_t qfpIndex = 0;
bool supportsGraphicsAndPresent =
std::ranges::any_of(queueFamilies,
[&physicalDevice, &surface = this->surface, &qfpIndex](auto const &qfp) {
bool const suitable = (qfp.queueFlags & vk::QueueFlagBits::eGraphics) && physicalDevice.getSurfaceSupportKHR(qfpIndex, *surface);
qfpIndex++;
return suitable;
});

// Check if all required physicalDevice extensions are available
auto availableDeviceExtensions = physicalDevice.enumerateDeviceExtensionProperties();
Expand All @@ -200,7 +207,7 @@ class HelloTriangleApplication
features.template get<vk::PhysicalDeviceExtendedDynamicStateFeaturesEXT>().extendedDynamicState;

// Return true if the physicalDevice meets all the criteria
return supportsVulkan1_3 && supportsGraphics && supportsAllRequiredExtensions && supportsRequiredFeatures;
return supportsVulkan1_3 && supportsGraphicsAndPresent && supportsAllRequiredExtensions && supportsRequiredFeatures;
}

void pickPhysicalDevice()
Expand Down
15 changes: 11 additions & 4 deletions attachments/10_fixed_functions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,9 +179,16 @@ class HelloTriangleApplication
// Check if the physicalDevice supports the Vulkan 1.3 API version
bool supportsVulkan1_3 = physicalDevice.getProperties().apiVersion >= VK_API_VERSION_1_3;

// Check if any of the queue families support graphics operations
auto queueFamilies = physicalDevice.getQueueFamilyProperties();
bool supportsGraphics = std::ranges::any_of(queueFamilies, [](auto const &qfp) { return !!(qfp.queueFlags & vk::QueueFlagBits::eGraphics); });
// Check if any of the queue families support both graphics and presentation to our surface
auto queueFamilies = physicalDevice.getQueueFamilyProperties();
uint32_t qfpIndex = 0;
bool supportsGraphicsAndPresent =
std::ranges::any_of(queueFamilies,
[&physicalDevice, &surface = this->surface, &qfpIndex](auto const &qfp) {
bool const suitable = (qfp.queueFlags & vk::QueueFlagBits::eGraphics) && physicalDevice.getSurfaceSupportKHR(qfpIndex, *surface);
qfpIndex++;
return suitable;
});

// Check if all required physicalDevice extensions are available
auto availableDeviceExtensions = physicalDevice.enumerateDeviceExtensionProperties();
Expand All @@ -202,7 +209,7 @@ class HelloTriangleApplication
features.template get<vk::PhysicalDeviceExtendedDynamicStateFeaturesEXT>().extendedDynamicState;

// Return true if the physicalDevice meets all the criteria
return supportsVulkan1_3 && supportsGraphics && supportsAllRequiredExtensions && supportsRequiredFeatures;
return supportsVulkan1_3 && supportsGraphicsAndPresent && supportsAllRequiredExtensions && supportsRequiredFeatures;
}

void pickPhysicalDevice()
Expand Down
15 changes: 11 additions & 4 deletions attachments/12_graphics_pipeline_complete.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,9 +180,16 @@ class HelloTriangleApplication
// Check if the physicalDevice supports the Vulkan 1.3 API version
bool supportsVulkan1_3 = physicalDevice.getProperties().apiVersion >= VK_API_VERSION_1_3;

// Check if any of the queue families support graphics operations
auto queueFamilies = physicalDevice.getQueueFamilyProperties();
bool supportsGraphics = std::ranges::any_of(queueFamilies, [](auto const &qfp) { return !!(qfp.queueFlags & vk::QueueFlagBits::eGraphics); });
// Check if any of the queue families support both graphics and presentation to our surface
auto queueFamilies = physicalDevice.getQueueFamilyProperties();
uint32_t qfpIndex = 0;
bool supportsGraphicsAndPresent =
std::ranges::any_of(queueFamilies,
[&physicalDevice, &surface = this->surface, &qfpIndex](auto const &qfp) {
bool const suitable = (qfp.queueFlags & vk::QueueFlagBits::eGraphics) && physicalDevice.getSurfaceSupportKHR(qfpIndex, *surface);
qfpIndex++;
return suitable;
});

// Check if all required physicalDevice extensions are available
auto availableDeviceExtensions = physicalDevice.enumerateDeviceExtensionProperties();
Expand All @@ -203,7 +210,7 @@ class HelloTriangleApplication
features.template get<vk::PhysicalDeviceExtendedDynamicStateFeaturesEXT>().extendedDynamicState;

// Return true if the physicalDevice meets all the criteria
return supportsVulkan1_3 && supportsGraphics && supportsAllRequiredExtensions && supportsRequiredFeatures;
return supportsVulkan1_3 && supportsGraphicsAndPresent && supportsAllRequiredExtensions && supportsRequiredFeatures;
}

void pickPhysicalDevice()
Expand Down
15 changes: 11 additions & 4 deletions attachments/14_command_buffers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,9 +185,16 @@ class HelloTriangleApplication
// Check if the physicalDevice supports the Vulkan 1.3 API version
bool supportsVulkan1_3 = physicalDevice.getProperties().apiVersion >= VK_API_VERSION_1_3;

// Check if any of the queue families support graphics operations
auto queueFamilies = physicalDevice.getQueueFamilyProperties();
bool supportsGraphics = std::ranges::any_of(queueFamilies, [](auto const &qfp) { return !!(qfp.queueFlags & vk::QueueFlagBits::eGraphics); });
// Check if any of the queue families support both graphics and presentation to our surface
auto queueFamilies = physicalDevice.getQueueFamilyProperties();
uint32_t qfpIndex = 0;
bool supportsGraphicsAndPresent =
std::ranges::any_of(queueFamilies,
[&physicalDevice, &surface = this->surface, &qfpIndex](auto const &qfp) {
bool const suitable = (qfp.queueFlags & vk::QueueFlagBits::eGraphics) && physicalDevice.getSurfaceSupportKHR(qfpIndex, *surface);
qfpIndex++;
return suitable;
});

// Check if all required physicalDevice extensions are available
auto availableDeviceExtensions = physicalDevice.enumerateDeviceExtensionProperties();
Expand All @@ -208,7 +215,7 @@ class HelloTriangleApplication
features.template get<vk::PhysicalDeviceExtendedDynamicStateFeaturesEXT>().extendedDynamicState;

// Return true if the physicalDevice meets all the criteria
return supportsVulkan1_3 && supportsGraphics && supportsAllRequiredExtensions && supportsRequiredFeatures;
return supportsVulkan1_3 && supportsGraphicsAndPresent && supportsAllRequiredExtensions && supportsRequiredFeatures;
}

void pickPhysicalDevice()
Expand Down
15 changes: 11 additions & 4 deletions attachments/15_hello_triangle.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,16 @@ class HelloTriangleApplication
// Check if the physicalDevice supports the Vulkan 1.3 API version
bool supportsVulkan1_3 = physicalDevice.getProperties().apiVersion >= VK_API_VERSION_1_3;

// Check if any of the queue families support graphics operations
auto queueFamilies = physicalDevice.getQueueFamilyProperties();
bool supportsGraphics = std::ranges::any_of(queueFamilies, [](auto const &qfp) { return !!(qfp.queueFlags & vk::QueueFlagBits::eGraphics); });
// Check if any of the queue families support both graphics and presentation to our surface
auto queueFamilies = physicalDevice.getQueueFamilyProperties();
uint32_t qfpIndex = 0;
bool supportsGraphicsAndPresent =
std::ranges::any_of(queueFamilies,
[&physicalDevice, &surface = this->surface, &qfpIndex](auto const &qfp) {
bool const suitable = (qfp.queueFlags & vk::QueueFlagBits::eGraphics) && physicalDevice.getSurfaceSupportKHR(qfpIndex, *surface);
qfpIndex++;
return suitable;
});

// Check if all required physicalDevice extensions are available
auto availableDeviceExtensions = physicalDevice.enumerateDeviceExtensionProperties();
Expand All @@ -217,7 +224,7 @@ class HelloTriangleApplication
features.template get<vk::PhysicalDeviceExtendedDynamicStateFeaturesEXT>().extendedDynamicState;

// Return true if the physicalDevice meets all the criteria
return supportsVulkan1_3 && supportsGraphics && supportsAllRequiredExtensions && supportsRequiredFeatures;
return supportsVulkan1_3 && supportsGraphicsAndPresent && supportsAllRequiredExtensions && supportsRequiredFeatures;
}

void pickPhysicalDevice()
Expand Down
15 changes: 11 additions & 4 deletions attachments/16_frames_in_flight.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,9 +196,16 @@ class HelloTriangleApplication
// Check if the physicalDevice supports the Vulkan 1.3 API version
bool supportsVulkan1_3 = physicalDevice.getProperties().apiVersion >= VK_API_VERSION_1_3;

// Check if any of the queue families support graphics operations
auto queueFamilies = physicalDevice.getQueueFamilyProperties();
bool supportsGraphics = std::ranges::any_of(queueFamilies, [](auto const &qfp) { return !!(qfp.queueFlags & vk::QueueFlagBits::eGraphics); });
// Check if any of the queue families support both graphics and presentation to our surface
auto queueFamilies = physicalDevice.getQueueFamilyProperties();
uint32_t qfpIndex = 0;
bool supportsGraphicsAndPresent =
std::ranges::any_of(queueFamilies,
[&physicalDevice, &surface = this->surface, &qfpIndex](auto const &qfp) {
bool const suitable = (qfp.queueFlags & vk::QueueFlagBits::eGraphics) && physicalDevice.getSurfaceSupportKHR(qfpIndex, *surface);
qfpIndex++;
return suitable;
});

// Check if all required physicalDevice extensions are available
auto availableDeviceExtensions = physicalDevice.enumerateDeviceExtensionProperties();
Expand All @@ -220,7 +227,7 @@ class HelloTriangleApplication
features.template get<vk::PhysicalDeviceExtendedDynamicStateFeaturesEXT>().extendedDynamicState;

// Return true if the physicalDevice meets all the criteria
return supportsVulkan1_3 && supportsGraphics && supportsAllRequiredExtensions && supportsRequiredFeatures;
return supportsVulkan1_3 && supportsGraphicsAndPresent && supportsAllRequiredExtensions && supportsRequiredFeatures;
}

void pickPhysicalDevice()
Expand Down
15 changes: 11 additions & 4 deletions attachments/17_swap_chain_recreation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,9 +229,16 @@ class HelloTriangleApplication
// Check if the physicalDevice supports the Vulkan 1.3 API version
bool supportsVulkan1_3 = physicalDevice.getProperties().apiVersion >= VK_API_VERSION_1_3;

// Check if any of the queue families support graphics operations
auto queueFamilies = physicalDevice.getQueueFamilyProperties();
bool supportsGraphics = std::ranges::any_of(queueFamilies, [](auto const &qfp) { return !!(qfp.queueFlags & vk::QueueFlagBits::eGraphics); });
// Check if any of the queue families support both graphics and presentation to our surface
auto queueFamilies = physicalDevice.getQueueFamilyProperties();
uint32_t qfpIndex = 0;
bool supportsGraphicsAndPresent =
std::ranges::any_of(queueFamilies,
[&physicalDevice, &surface = this->surface, &qfpIndex](auto const &qfp) {
bool const suitable = (qfp.queueFlags & vk::QueueFlagBits::eGraphics) && physicalDevice.getSurfaceSupportKHR(qfpIndex, *surface);
qfpIndex++;
return suitable;
});

// Check if all required physicalDevice extensions are available
auto availableDeviceExtensions = physicalDevice.enumerateDeviceExtensionProperties();
Expand All @@ -253,7 +260,7 @@ class HelloTriangleApplication
features.template get<vk::PhysicalDeviceExtendedDynamicStateFeaturesEXT>().extendedDynamicState;

// Return true if the physicalDevice meets all the criteria
return supportsVulkan1_3 && supportsGraphics && supportsAllRequiredExtensions && supportsRequiredFeatures;
return supportsVulkan1_3 && supportsGraphicsAndPresent && supportsAllRequiredExtensions && supportsRequiredFeatures;
}

void pickPhysicalDevice()
Expand Down
Loading
Loading