Repository navigation
Fix #388, #368, #369: .lua and .css as text, snap the crop frame to the centre - #393
Merged
KnifeLemon merged 3 commits intoOct 23, 2026
Merged
Conversation
…KnifeLemon#368) Like the scripts and logs 2.0.0 added: the TXT format takes .lua and .css, so they convert to PDF, Markdown, DOCX and the other text targets, read and never run. Settings schema 33 teaches existing text donuts the extensions unless a donut of the user already claims them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ifeLemon#369) When the moved frame's centre comes within 8 screen pixels of the picture's vertical or horizontal centre line, it snaps onto it and a dashed accent guide shows that line across the picture until the drag ends. A frame as wide (or tall) as the picture never counts as snapped. Keyboard nudges stay pixel-exact and don't snap. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ENGINES.md lists LUA and CSS with the plain-text formats; ARCHITECTURE.md describes the snap to the picture's centre lines in the crop overlay. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 22, 2026
Closed
Closed
Owner
|
Thanks a lot, @cre8ive-marketing, three small issues in one tidy PR, with tests for each and a real headless drag for the snapping. The crop snapping looks right to me: it only snaps while the frame is moved, the guide disappears when the drag ends, arrow-key nudges stay pixel-exact, and a full-width or full-height frame never counts as snapped. I've started the CI run. On the schema: since #351 keeps 33, this step becomes 34. |
This was referenced Oct 22, 2026
This was referenced Oct 22, 2026
Closed
Owner
|
Merged through #464, thanks @cre8ive-marketing! Its settings migration became schema 34 (after #351). It'll be in the next release. |
KnifeLemon
added a commit
to cre8ive-marketing/Filee
that referenced
this pull request
Oct 23, 2026
Main took settings schema 33 for KnifeLemon#351, so the Lua / CSS text-donut step becomes v34 after it, AppSettings.CurrentSchemaVersion goes to 34 and the migration test starts from 33. KnifeLemon#393 adds no UI strings; all 13 language files already match en.json. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
KnifeLemon
added a commit
to cre8ive-marketing/Filee
that referenced
this pull request
Oct 23, 2026
The HP-GL plot-file step becomes v35 after KnifeLemon#393's v34, AppSettings.CurrentSchemaVersion goes to 35 and the migration test starts from 34. KnifeLemon#432 adds no UI strings; all 13 language files already match en.json. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Three small issues opened since 2.0.0, one commit each.
.lua, #368.cssCropMath.SnapToCentre.Docs:
ENGINES.mdlists LUA and CSS with the plain-text formats;ARCHITECTURE.mddescribes the crop snapping.How was it tested?
dotnet format --verify-no-changesdotnet test: all pass with FFmpeg 9.0.2 and rhwp 0.8.7 installed: Core 457, App 774, Engines 1442, Setup 134, Cli 27, Platform 48 (0 failed).ScriptTextTests(Core):.lua/.cssare detected as TXT, and the schema 33 upgrade keeps a user's own claim.ScriptTextTests(Engines, with rhwp): a.cssand a.luafile become a PDF holding their text.CropMathTests: snapping inside, at and just outside 8 px, and a full-width frame.CropOverlayTests.A_frame_moved_near_the_middle_snaps_to_the_centre_lines: a real headless drag that ends 3 px short of the centre lands exactly centred.Screenshots (UI changes)
The new UI test saves
crop-snap-en.png(intests/Filee.App.Tests/bin/<config>/net10.0/screenshots): the frame snapped on both axes, with the two dashed guides. I can attach it here from the web if wanted.Checklist
src/Filee.App/Assets/i18n/*.jsonfiles (none added)THIRD-PARTY-NOTICES.md(none)Fixes #388, fixes #368, fixes #369.