Repository navigation
[Common] Use VR TMA override instruction for quantization kernels - #3879
Oleg-Goncharov wants to merge 9 commits into
Conversation
Signed-off-by: Oleg Goncharov <ogoncharov@nvidia.com>
Signed-off-by: Oleg Goncharov <ogoncharov@nvidia.com>
Signed-off-by: Oleg Goncharov <ogoncharov@nvidia.com>
Signed-off-by: Oleg Goncharov <ogoncharov@nvidia.com>
5a76ca3 to
519ba9a
Compare
for more information, see https://pre-commit.ci
Signed-off-by: Oleg Goncharov <ogoncharov@nvidia.com>
Signed-off-by: Oleg Goncharov <ogoncharov@nvidia.com>
for more information, see https://pre-commit.ci
[Medium impact] The new transfer path reaches three grouped MXFP8 operations on Rubin. The PR appears safe to merge, with a non-blocking gap in tests for groups above 64 members. Findings
SummaryAdds Rubin instruction-local TMA overrides to grouped MXFP8 quantization, dequantization, and requantization.
Diagram%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Grouped MXFP8 operation] --> B{Rubin and CUDA 13.4 or later?}
B -->|Yes, varying width| C[Create small template maps]
C --> D[Read group dimensions and offsets]
D --> E[Transfer each stage with local overrides]
B -->|No, varying width| F[Update per-group descriptor table]
F --> G[Acquire descriptors and transfer stages]
B -->|Common width| H[Use existing single-map path]
Reviews (1) · Last reviewed commit: "[pre-commit.ci] auto fixes from pre-comm..." · Reviewed by Greptile |
| if (test_case.shapes.size() > 64 && test::getDeviceComputeCapability() != 107) { | ||
| GTEST_SKIP() << "More than 64 grouped TMA descriptors requires Rubin overrides."; | ||
| } |
There was a problem hiding this comment.
Larger groups lack test coverage
The new skip never runs: kGroupShapeCases has at most 40 members, and both varying-width cases have only three. Add cases with at least 65 members for VARYING_LAST_DIM and VARYING_BOTH_DIMS, including empty members near the old limit. Otherwise, this suite cannot catch regressions in the newly allowed path that bypasses the 64-entry table.
Knowledge Base Used: Verification and CI matrix
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Description
Use Rubin (SM107) instruction-local TMA overrides in native grouped MXFP8 quantization, dequantization, and requantization. For groups with varying last or both dimensions, pass the stage address, dimensions, and stride directly to the TMA load or store. This removes the descriptor-update kernel and per-group descriptor publication and acquire on that path.
Type of change
Changes
sm_107afor architecture-specific kernels when CMake is configured with107, and deduplicate architecture-specific targets.Checklist: