Repository navigation
[Common] Use VR TMA override instruction for quantization kernels #3879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Oleg-Goncharov
wants to merge
9
commits into
NVIDIA:main
Choose a base branch
from
Oleg-Goncharov:pr_rubin_tma_override
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+403
−181
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e4b3877
Implemented TMA override path for Rubin arch
Oleg-Goncharov 5659dba
Merge branch 'main' into pr_rubin_tma_override
Oleg-Goncharov a09df0b
Small refactoring
Oleg-Goncharov 111d6cd
Refactoring
Oleg-Goncharov 519ba9a
Small refactoring
Oleg-Goncharov 2fad236
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] e1ea40f
Small refactoring
Oleg-Goncharov e1d21b7
Small refactoring
Oleg-Goncharov 43d08b5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new skip never runs:
kGroupShapeCaseshas at most 40 members, and both varying-width cases have only three. Add cases with at least 65 members forVARYING_LAST_DIMandVARYING_BOTH_DIMS, including empty members near the old limit. Otherwise, this suite cannot catch regressions in the newly allowed path that bypasses the 64-entry table.Knowledge Base Used: Verification and CI matrix
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!