Repository navigation
scripts: convert JavaScript to TypeScript - #156
Merged
Merged
Conversation
Assisted-by: gpt-6.1-sol (Codex, high)
mdaniels5757
requested review from
MattSturgeon and
philiptaron
as code owners
October 18, 2026 00:14
Pandapip1
reviewed
Oct 19, 2026
| @@ -415,7 +447,10 @@ module.exports = async function retire({ github, options }) { | |||
| if (pr) { | |||
| await effect( | |||
| () => | |||
| github.request(`POST /repos/${org}/${memberRepo}/issues/${pr.data.number}/labels`, { | |||
Member
There was a problem hiding this comment.
Seems like actual code changes like this should be at least in a separate commit?
Member
Author
There was a problem hiding this comment.
Late, but the reason I didn't do this was that the original code didn't type-check.
Member
There was a problem hiding this comment.
I figured about as much, but AFAICT there's no reason that the code change couldn't have been made while it remained JS, then be moved to TS. This is moot now that it's merged anyway.
philiptaron
approved these changes
Oct 21, 2026
@actions/artifact, bottleneck and commander aren't imported by any script. Removing them shrinks the lockfile from 196 to 50 packages.
Without this, type errors in the scripts are only caught when someone runs `npm test` locally.
Terminate type aliases and members with semicolons like the rest of the code, fix the indentation of the downloadArtifact call, and drop a trailing space in shell.nix.
TypeScript 7 always enables it and no longer allows turning it off.
philiptaron
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested locally.