Repository navigation
ExtractMixin verdicts skip INHERITED_DECLARATION guards - #357
Merged
Merged
Conversation
For ExtractMixin moves, inherited declarations don't block the verdict: the recipe synthesizer already filters inherited names from the block at line 2621-2623 via candidate.inherited_names (which reads from overlap.inherited, not from receipts). The receipt was informational, not a real constraint for mixin extraction. This unblocks 3 more missing_mixin verdicts on agent-comms: SelectedExecution/ForegroundOwner, FencedOwnerBatch/StoppedOwnerBatch, ContributionCoordinates/SegmentManifest. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RnH6dR7JdknxC8XJJtW8Uh
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
trissim
pushed a commit
that referenced
this pull request
Nov 11, 2026
Positional construction is handled at the owner level as a keywording prerequisite (keyword_cure). It should not block the verdict itself for ExtractMixin moves. The owner candidate's _field_order_receipts produces the POSITIONAL_CONSTRUCTION guard with keyword cure; the recipe synthesizer checks owner.keyword_cure before the pick match. Unblocks 5 more missing_mixin verdicts on agent-comms: SessionFacts/ImportBuffer, BusRouteCounts/BusRouteKeys, RouteUnread/CursorRow, FailedTurnEvidence/GoalDerivedContact, HostMemoryHigh/HostResources (last also has DECLARATION_DIFFERS). Combined with PRs #357 and #358: 5 + 3 + 3 + 5 = up to 16 mixin ops. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RnH6dR7JdknxC8XJJtW8Uh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For ExtractMixin moves, INHERITED_DECLARATION receipts are no longer verdict-level guards. The recipe synthesizer already handles inherited names by filtering them from the block at line 2621-2623 via
candidate.inherited_names(reads fromoverlap.inherited, not receipts). The guard was overly conservative for this move type.What changed
class_overlap.py:834: Skip_inherited_receiptswhenmove is ExtractMixintest_extract_mixin_verdict_not_blocked_by_inheritedverifies ExtractMixin verdicts with inherited declarations are permittedImpact on agent-comms
Unblocks 3 more missing_mixin verdicts that were BLOCKED only by INHERITED_DECLARATION:
Combined with the previous
tolerate_inheritedfix atrequire_owner_candidate, total missing_mixin ops: 5 mixin + 3 newly unblocked = up to 8.Evidence
5/5 tests green (4 existing + 1 new). The
inherited_namesproperty reads fromoverlap.inherited, completely independent of receipts — removing the receipt loses no information.Generated by Claude Code