Repository navigation
flatten_tuple_return reuses a shared TypeCheckerSession - #361
Merged
Merged
Conversation
A module-level _shared_type_checker_session lets batch callers start one mypy session and share it across multiple FlattenTupleReturnOperation runs. Without sharing, each op boots a fresh mypy daemon on all modules (~2 min per target on 842 modules). With sharing, the first op pays the startup and every subsequent op is a lookup. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RnH6dR7JdknxC8XJJtW8Uh
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A module-level
_shared_type_checker_sessionlets batch callers start one mypy session and share it across multipleFlattenTupleReturnOperationruns. Without sharing, each op boots a fresh mypy daemon on all modules (~2 min per target on 842 modules). With sharing, the first op pays the startup and every subsequent op is a type lookup.What changed
return_shape.py: Module-level_shared_type_checker_sessionvariable.source_edits_from_snapshotuses it when set, only stopping the session if it owns it.Evidence
7/7 tests pass.
Generated by Claude Code