Skip to content

flatten_tuple_return reuses a shared TypeCheckerSession #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trissim merged 1 commit into from
Nov 11, 2026
Merged

flatten_tuple_return reuses a shared TypeCheckerSession #361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions nominal_refactor_advisor/refactors/return_shape.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
from nominal_refactor_advisor.refactors.answered_method import AnsweredMethod, AnsweredUse
from nominal_refactor_advisor.type_checker_session import SourceTexts, TypeCheckerSession

_shared_type_checker_session: TypeCheckerSession | None = None


def _tuple_return_kind(node: ast.Return) -> str | None:
"""Classify a return statement as zero-or-one tuple, or None if other."""
Expand Down Expand Up @@ -179,11 +181,16 @@ def add(file_path: str, start: int, end: int, text: str) -> None:
add(resolved_class.file_path, start, end, new_annotation)

answered = AnsweredMethod(snapshot, base, function)
session = TypeCheckerSession.started(SourceTexts(snapshot.parsed_modules))
shared = _shared_type_checker_session
owned_session = shared is None
session = shared or TypeCheckerSession.started(
SourceTexts(snapshot.parsed_modules)
)
try:
calls = answered.answering_calls(session)
finally:
session.stop()
if owned_session:
session.stop()

for use in calls:
geo = geometry(use.file_path)
Expand Down
Loading