Repository navigation
Keep inspected session settings and focus with their original owners - #1758
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
debt-src at c7eaeb6 blocks on 2 lines: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sidebar follow-up from the physical check
The settings inspector now uses only the selected session's actual advertisements. The existing model popup keeps its provider-setup entry through its inherited settings projection. An inline advertisement update no longer steals keyboard focus; the popup retains its original focus behavior. Both use the same SessionForm and original writer.
Discovered settings groups appear before session-specific entries, and a stopped/unadvertised session says so explicitly. The physical observation helper now reads retained coverage from the original coverage owner; a temporary geometry diagnostic was removed after identifying the shared Textual nesting defect.
The main declaration discovery, lazy inheritance, global saves and selected-object state are already merged in #1755. This follows the actual installed physical check: keyboard selection showed Notifications fields, but the dropdown was underneath its containing overlay. That independent owner fix is Textual #309.
Focused controls
Original agent-configuration controls: 2 passed. The UI attempt stopped during helper launch because the inherited file limit was 1024 and its native FD relocation starts at 1024; no form ran. Rerun of only that original UI case with the existing 4096 launch limit: 1 passed in 18.80s, exit 0, against this Toad source and the fixed Textual source. It covers selected channel/file state, global edits, local inheritance/reset, context-menu form identity and changing native advertisements. No broad suite or profiling.
Native plans are in
.verification/object-settings-sources/. Installed isolated st/Xvfb run visually confirmed the original group dropdown and generated Notifications fields with their scope labels. Native parallel-pi received and answered after restart. The later physical channel check hit a helper-only cursor assumption; that limitation and the separate helper repair are recorded in .verification/object-settings-sources/physical-delivery.md (Toad #1759). Selected channel/file behavior passed the focused UI case above. Test window and private workers are closed.