Repository navigation
Keep physical history inspection on the coverage owner - #1759
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finish the actual sidebar inspection
The installed physical run visibly confirmed the generated dropdown and Notifications fields (Toad #1758 / Textual #309). Switching to a channel then exposed an observation helper error: it asked WireHistory for a native transcript cursor just to learn whether saved history was available.
HistoryCoverage now owns that question directly; PageCoverage answers true, the uncovered family answers false. The helper calls it without touching source-specific cursor APIs. No cache, subtype probe or per-history workaround. Native plans applied; source trace covers all coverage states and the sole helper consumer. No extra app run or test suite.
The physical dropdown also had two different entries named Agent settings. The selected session's advertisement panel is now Session settings; global Agent settings retains its declared name. Original identities and writers are unchanged.
Complete results, exact installed build, screenshots and the failed physical channel check are retained in
.verification/object-settings-sources/physical-delivery.md. This follow-up does not claim that final channel screenshot passed.