Repository navigation
Bind New Thread viewport check to the Service Tier declaration - #1763
Merged
Merged
Conversation
trissim
marked this pull request as ready for review
November 13, 2026 05:51
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P216: bind the viewport control to its declared catalog
Core #4676 correctly moves complete inherited settings into New Thread. This changes dataclass field order: Project is now last. The P210 regression case incorrectly assumed the final field was a Select.
Use
ServiceTierConfigOption.declared_field().nameinstead. No copied name string, roster or product-layout change. Preserve the real dropdown-open assertion, fixed-footer hit checks, scrolling and first-click submission.The one original case passed at low priority against the combined runtime
core-93f6be9e7-lock-536d23f0a12ccd21: 1 passed in 14.24 s, exit 0. It opens the Service Tier dropdown, scrolls and retains fixed-footer access, then submits on the first click. No new provider call, worktree, broad suite or installer. Full output:p216-installed-ui.logbeside the native plan. No physical UI claim.Native plan and full output:
/home/ts/.cache/agent-scratch/parallel-pi/p216-*. This is a test-declaration correction following the Core inheritance change, not another form implementation.