Skip to content

Bind New Thread viewport check to the Service Tier declaration #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trissim merged 1 commit into from
Nov 13, 2026
Merged

Bind New Thread viewport check to the Service Tier declaration #1763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/textual/test_application_actions_in_the_running_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
"""Textual-facing: application actions (help, settings screen, command palette, sidebar buttons, tab close) run through Textual screens and keep the session, its draft and the saved settings."""
from agent_comms.config_options import ServiceTierConfigOption
from agent_comms.nominal.field_codec import FieldCodec
from toad.forms.editors import ChoicesEditor
from toad.launch_binding import AgentAttached
Expand Down Expand Up @@ -189,12 +190,12 @@ def call(self, request):
button = dialog.query_one(ApplyCommandButton)
await ui.until(lambda: not button.disabled, why="the command values to be accepted")
await ui.until_clickable(button, why="the fixed create control to remain visible before scrolling")
lower = next(reversed(dialog.form.values.values())).editor
lower = dialog.form.values[ServiceTierConfigOption.declared_field().name].editor
lower.scroll_visible(animate=False, immediate=True)
assert isinstance(lower, ChoicesEditor)
await ui.step()
await ui.textual[1].click(lower, offset=(3, 1))
await ui.until(lambda: lower.expanded, why="the scrolled lower field to open its actual choices")
await ui.until(lambda: lower.expanded, why="the scrolled service-tier field to open its actual choices")
await ui.press('escape')
assert dialog.query_one(CommandFormScroll).scroll_y > 0
await ui.until_clickable(button, why="the fixed create control to remain visible after scrolling")
Expand Down
Loading