Skip to content

fix main's test run: missing translations and gallery case - #683

Merged
abdulsaheel merged 2 commits into
mainfrom
fix/l10n-report-contact
Nov 10, 2026
Merged

abdulsaheel merged 2 commits into
mainfrom
fix/l10n-report-contact

Conversation

@abdulsaheel

@abdulsaheel abdulsaheel commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

main has been red since #680. report contact strings missing for es, fr, hi, zh. firmware warning strings missing for ru and th. WhoopFirmwareWarning not in the gallery. the picker search test needs a taller surface now that the banner sits above the list.

Summary by Sourcery

Restore localization coverage and gallery/test support for the firmware warning UI.

Bug Fixes:

  • Restore missing localized report-contact and firmware-warning strings across the affected languages.
  • Ensure the firmware warning component is available in the profile gallery and stabilize the picker search test for the banner layout.

Tests:

  • Adjust the picker search widget test surface to account for the firmware warning banner.

Summary by CodeRabbit

  • Localization
    • Added translated labels and guidance for optional contact details in the report form in Spanish, French, Hindi, and Chinese. The guidance clarifies that an email address or Discord handle is only needed if a reply is desired.
    • Added Russian and Thai text for a WHOOP firmware warning covering reported data-access issues with versions 50.43.1.0 and 50.43.2.0, the risk of reconnecting to the official app, and the lack of a current fix.
  • New Features
    • Added a WHOOP firmware warning to the app’s gallery of cases.

@sourcery-ai

sourcery-ai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Reviewer's Guide

Data structures

Add the missing report-contact translations for Spanish, French, Hindi, and Chinese so localization checks pass.

  • lib/l10n/app_es.arb L2893-2895
  • lib/l10n/app_fr.arb L2864-2866
  • lib/l10n/app_hi.arb L2864-2866
  • lib/l10n/app_zh.arb L2864-2866

Add the Russian and Thai translations required by the firmware warning.

  • lib/l10n/app_ru.arb L7907-7910
  • lib/l10n/app_th.arb L16328-16331

UI

Import and add WhoopFirmwareWarning to the gallery component cases so the warning can be viewed there.

  • lib/ui2/profile/gallery.dart L56, L214

Tests

Give the picker search test a taller surface so the filtered row remains built below the firmware banner.

  • test/russian_review_findings_test.dart L330-333

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Spanish, French, Hindi, and Chinese localizations add optional report contact labels and hints. Russian and Thai localizations add WHOOP firmware warning text. The profile gallery adds a case that renders the warning widget.

Changes: Report contact localizations

Layer / File(s) Summary
Add optional contact strings
lib/l10n/app_es.arb, lib/l10n/app_fr.arb, lib/l10n/app_hi.arb, lib/l10n/app_zh.arb
Each locale adds a label for optional contact details and a hint that names email or Discord as contact methods for users who want a reply.

WHOOP firmware warning

Layer / File(s) Summary
Localize and expose the firmware warning
lib/l10n/app_ru.arb, lib/l10n/app_th.arb, lib/ui2/profile/gallery.dart
Russian and Thai add warning text about affected firmware versions, the stated token limitation, and the absence of a current fix. The profile gallery adds a case that renders WhoopFirmwareWarning.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related PRs

  • OpenStrap/edge#664: Adds the optional report contact field and defines its labels in other locales.

Suggested reviewers: tahir101981-creator, chayapats

Merge Risk: Minimal · up to aa5b1

No actionable merge-blocking risk was identified. Normal localization checks should still run before release.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title identifies the missing translations and gallery case, which match changes in the pull request. It does not mention the WHOOP firmware warning strings, but the title does not need to cover ev…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title identifies the missing translations and gallery case, which match changes in the pull request. It does not mention the WHOOP firmware warning strings, but the title does not need to cover every change.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 85ecde1 and aa5b160.

Files ignored due to path filters: 1

  • test/russian_review_findings_test.dart is excluded by !test/**
Files selected for processing: 3

  • lib/l10n/app_ru.arb
  • lib/l10n/app_th.arb
  • lib/ui2/profile/gallery.dart

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

(Review updated until commit aa5b160)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ No major issues detected

@github-actions

Copy link
Copy Markdown
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

…ry case for it, taller surface for the picker search test
@abdulsaheel abdulsaheel changed the title l10n: add report contact strings for es, fr, hi, zh fix main's test run: missing translations and gallery case Nov 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Persistent review updated to latest commit aa5b160

@github-actions

Copy link
Copy Markdown
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sourcery assessment

Approved.

@abdulsaheel
abdulsaheel merged commit 802b30f into main Nov 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant