Skip to content

fix: pin reader to seamless EPUB pagination update - #101

Merged
Eoic merged 1 commit into
developmentfrom
fix/pin-seamless-reader
Oct 28, 2026
Merged

Eoic merged 1 commit into
developmentfrom
fix/pin-seamless-reader

Conversation

@Eoic

@Eoic Eoic commented Oct 28, 2026

Copy link
Copy Markdown
Member

Issue and requirements

Closes #100. Covers EPUB navigation and pagination under FR-3_1 and FR-3_2.

Depends on PapyrusReader/reader#10. Merge the reader PR first.

Summary

Pin papyrus_reader to 865e94adffe957042cd2a6107173bd05a78a3e87 in the manifest and lockfile so Git-resolved client builds include incremental EPUB pagination, animated boundary turns, and consistent page counts. The change is limited to the manifest ref and the lockfile ref/resolved-ref.

Testing

  • In an isolated checkout without pubspec_overrides.yaml, flutter pub get --enforce-lockfile passed and resolved the reader from the Git cache at the exact pinned SHA.
  • All 22 tests in reader_session_test.dart, reader_page_test.dart, reader_theme_test.dart, and reader_location_persistence_test.dart passed against that Git dependency.
  • tools/papyrus check client passed: formatting, analysis, and web-bootstrap checks.
  • git diff --check passed.

UI evidence

The reader PR records desktop/mobile browser verification of page turns and page counts. This PR only updates the dependency pin.

Compatibility and migration

No application version bump or data migration. Existing local path-override files are preserved and excluded from the commit.

Notes

The pinned reader commit is currently the head of reader PR #10. CI results are reported separately from local validation.

Checklist

  • The branch, commits, and pull request title follow the repository conventions.
  • The change is complete and limited to the agreed scope.
  • Relevant tests have been added or updated (reader regressions are in the dependency PR).
  • Formatting, analysis, and tests pass locally.
  • Documentation, UI evidence, and migration notes are included where relevant.
  • No credentials, personal data, copyrighted fixtures, or unrelated generated files are included.
  • The branch is up to date with its target branch.

Copilot AI balanced review requested due to automatic review settings October 28, 2026 22:36

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T22:36:57.161925Z 4aeff05 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Eoic
Eoic enabled auto-merge October 28, 2026 22:41
@Eoic
Eoic merged commit 0e78038 into development Oct 28, 2026
5 checks passed
@Eoic
Eoic deleted the fix/pin-seamless-reader branch October 28, 2026 22:46
@codecov

codecov Bot commented Oct 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the reader pin for seamless EPUB turns and consistent page counts

2 participants