Repository navigation
feat: import books from watched device folders - #109
Conversation
Refs #108. Add profile-local folder import recovery, native and browser access, Library management, and offline web packaging for FR-2_6.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a8b09fe7e6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Refs #108. Keep transient folder selections eligible for scheduled scans until file stability checks finish. Cover recent and unknown timestamps, future dates, and files changing during reads.
|
feat: import books from watched device folders feature was successfully merged into the development branch.
|
Issue and requirements
Closes #108. Implements the device-folder portion of FR-2_6. Documentation: PapyrusReader/docs#90.
Summary
Users can connect a folder from Library, preview its contents, and import local book copies while offline. Later scans add new files without replacing existing books or modifying their sources.
Testing
The workspace platform builds and live harness used the existing local reader override. The clean-checkout tests above and CI validate the committed dependency.
UI evidence
Responsive widget tests cover folder tables, setup/details/edit sheets, source filters, stable status/progress geometry, large text and e-ink. From
app/, generate review captures with:flutter test test/folders/watched_folders_page_test.dart --dart-define=FOLDER_DESIGN_CAPTURE=trueCaptures are written to ignored
build/folder-review/within the app directory. No generated captures are committed.Compatibility and migration
No new server endpoint, replicated field or server migration. Folder state remains in a separate profile-local database and guest libraries stay local. Existing imports use their current behavior unless a caller opts into a preallocated book ID.
The live test database required the existing
b9c0d1e2f345migration. Apple dependency minimums now match the app's existing iOS 15/macOS 12 requirements. Debug simulator builds use the host architecture.Notes
Windows native execution is pending CI. Physical picker, revoked-permission, bookmark, cloud-placeholder and removable-drive acceptance remain release checks in the documentation. Browser headless acceptance used real persisted handles with a substituted picker and does not establish OS-picker acceptance.
Checklist