Skip to content

Redesign Statistics around reading habits and recorded pages - #120

Merged
Eoic merged 3 commits into
developmentfrom
feature/statistics-reading-habits
Nov 2, 2026
Merged

Eoic merged 3 commits into
developmentfrom
feature/statistics-reading-habits

Conversation

@Eoic

@Eoic Eoic commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Statistics now presents a period-scoped reading-habits overview with reading time, pages, books finished and qualified reading days. Time and Pages share one bar chart, Week always shows Monday–Sunday, Month/Year show their full calendar axes, and totals and daily averages exclude future placeholders. Custom range stays right-aligned without shifting the controls. Adjacent cards match heights, empty states stay concise, and the totals drawer is removed.

Adds a persisted Left/Center alignment preference in Appearance, defaulting to Left with the same margins as other pages. Genre can be edited in book details and is persisted through existing metadata. Genre distribution counts books actually read in the selected period. The activity tracker preserves normalized chapter coverage and calibrated page estimates from the currently pinned reader. It also supports individual rendered pages from the companion reader change, with ten-second exposure, per-day deduplication and existing history preserved.

Fixes #119. Contributes to FR-5_1 (PapyrusReader/docs#34) and FR-5_2 (PapyrusReader/docs#35), without claiming their broader criteria complete.

Reader integration: the committed reader pin remains unchanged and its chapter-based calculation is preserved. PapyrusReader/reader#19 supplies individual rendered-page identities when integrated through the release process. Both dependency configurations pass the same focused client suite.

Validation:

  • Full client suite before the review fixes: 2,086 passed, 19 skipped.
  • After review fixes: 29 focused client tests pass against both the unchanged Git pin (isolated checkout, enforced lockfile, no override) and the updated local reader. This includes actual EPUB engine/navigation coverage.
  • tools/papyrus check client: formatting, analysis and all 17 JavaScript checks pass.
  • Companion reader: all 235 tests and reader quality checks pass.
  • Regression coverage includes complete calendar axes, consistent bars, responsive/e-ink/large-text layouts, stable controls, alignment persistence, genre persistence and activity upload round trips.
  • Synthetic Flutter screenshots were inspected locally for desktop/mobile charts and genre editing.

Live server replication and native-device/browser acceptance were not run. CI remains separate from these local results.

@codecov

codecov Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

@Eoic
Eoic marked this pull request as ready for review November 2, 2026 20:24
Copilot AI balanced review requested due to automatic review settings November 2, 2026 20:24
@Eoic
Eoic enabled auto-merge November 2, 2026 20:24
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T20:26:22.607526Z fa2dc49 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fa2dc49445

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Eoic
Eoic merged commit f40483a into development Nov 2, 2026
7 checks passed
@Eoic
Eoic deleted the feature/statistics-reading-habits branch November 2, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redesign reading statistics around reading habits

2 participants