Skip to content

Test and fix GitHub workflows - #8

Merged
namurphy merged 5 commits into
PlasmaPy:mainfrom
namurphy:github-workflows-3
Aug 26, 2026
Merged

Test and fix GitHub workflows#8
namurphy merged 5 commits into
PlasmaPy:mainfrom
namurphy:github-workflows-3

Conversation

@namurphy

@namurphy namurphy commented Aug 26, 2026

Copy link
Copy Markdown
Member

Description

Test that the GitHub workflows added in #6 are working.

Important

This pull request marks a milestone: getting our first CI failures with GitHub workflows! Time to party like it's 1999!

Motivation

Based on sensible security settings, the workflows had to be merged before being able to tell whether they are working or not.

Details

  • Remove token input in workflow to upgrade uv.lock

@namurphy

Copy link
Copy Markdown
Member Author

Just got ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ so it's ready to merge!

branch: upgrade-uv-lock
base: main
delete-branch: true
token: ${{ steps.generate_token.outputs.token }}

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The token step is no longer required for this GitHub action, so we can remove it. A possible consequence is that GitHub workflows won't be run automatically on the pull requests to upgrade uv.lock, so we might need to update this later.

Comment thread .github/zizmor.yml
Comment on lines +4 to +16
rules:
unpinned-uses:
config:
policies:
actions/*: ref-pin
astral-sh/setup-uv: ref-pin
codecov/codecov-action: ref-pin
conda-incubator/setup-miniconda: ref-pin
mamba-org/setup-micromamba: ref-pin
heliophysicsPy/pyhc-actions/*: ref-pin
pypa/*: ref-pin
scientific-python/*: ref-pin
ts-graphviz/setup-graphviz: ref-pin

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are GitHub actions repositories that we trust enough to not pin to an exact hash. Copied from PlasmaPy.

@namurphy
namurphy merged commit dc5ac6f into PlasmaPy:main Aug 26, 2026
10 checks passed
@namurphy
namurphy deleted the github-workflows-3 branch August 26, 2026 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant