-
Notifications
You must be signed in to change notification settings - Fork 1
Test and fix GitHub workflows #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6a43873
Remove token step from workflow to upgrade uv.lock
namurphy c73afdb
Merge branch 'main' of github.com:PlasmaPy/pyfaradaycup into github-w…
namurphy ee47380
Fix an import-ant static type checking error
namurphy a803869
Add configuration file for zizmor workflow security checks
namurphy 9fe378d
Update workflow permissions
namurphy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # zizmor finds potential security vulnerabilities in GitHub workflow | ||
| # files. Documentation: https://woodruffw.github.io/zizmor | ||
|
|
||
| rules: | ||
| unpinned-uses: | ||
| config: | ||
| policies: | ||
| actions/*: ref-pin | ||
| astral-sh/setup-uv: ref-pin | ||
| codecov/codecov-action: ref-pin | ||
| conda-incubator/setup-miniconda: ref-pin | ||
| mamba-org/setup-micromamba: ref-pin | ||
| heliophysicsPy/pyhc-actions/*: ref-pin | ||
| pypa/*: ref-pin | ||
| scientific-python/*: ref-pin | ||
| ts-graphviz/setup-graphviz: ref-pin | ||
|
Comment on lines
+4
to
+16
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These are GitHub actions repositories that we trust enough to not pin to an exact hash. Copied from PlasmaPy. |
||
|
|
||
| # Put settings that we intend to fix later on below this line. If we | ||
| # decide that a potential security vulnerability does not necessitate a | ||
| # fix, append a comment like `# zizmor: ignore[unpinned-uses]` to the | ||
| # line or set the appropriate configuration options above. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,6 +24,7 @@ | |
| import os | ||
|
|
||
| import nox | ||
| import nox.command | ||
| import nox_uv | ||
|
|
||
| nox.options.default_venv_backend = "uv" | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The token step is no longer required for this GitHub action, so we can remove it. A possible consequence is that GitHub workflows won't be run automatically on the pull requests to upgrade
uv.lock, so we might need to update this later.