Repository navigation
Include all of the IPv6 address in homa_qdisc_can_bypass - #137
Open
randomizedcoder wants to merge 1 commit into
Open
randomizedcoder wants to merge 1 commit into
randomizedcoder wants to merge 1 commit into
Conversation
* homa_qdisc_can_bypass hashed the new packet's IPv6 destination as words 0^2^3 but each deferred packet's as 0^1^2^3. For any address whose second word is nonzero the two never match, so a TCP packet could bypass deferred packets of the same flow and be reordered. * The existing test uses IPv4-mapped addresses (word 1 is zero), which hid the mismatch; the new test uses a real IPv6 address. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
randomizedcoder
added a commit
to randomizedcoder/HomaModule
that referenced
this pull request
Oct 29, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
homa_qdisc_can_bypasshashed the new packet's IPv6 destination as words0^2^3, but each deferred packet's as0^1^2^3. For any real IPv6 address (nonzero second word) they never match, so a TCP packet can bypass deferred packets of the same flow and be reordered.u6_addr32[1].homa_qdisc_can_bypass__ipv6_address_uses_all_words. The existing test uses IPv4-mapped addresses, whose word 1 is zero, which hid this.Verified: the new test fails before the fix and passes after; full unit suite 885/885 in both IPv6 and
--ipv4modes;homa.kocompiles warning-free on 7.3, normal and__STRIP__=1; checkpatch clean.🤖 Generated with Claude Code