Skip to content

Include all of the IPv6 address in homa_qdisc_can_bypass #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
randomizedcoder wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −0
Open

Include all of the IPv6 address in homa_qdisc_can_bypass #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions homa_qdisc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,6 +651,7 @@ bool homa_qdisc_can_bypass(struct sk_buff *skb, struct homa_qdisc *q)
if (ipv6_hdr(skb)->nexthdr != IPPROTO_TCP)
return false;
daddr = ipv6_hdr(skb)->daddr.in6_u.u6_addr32[0] ^
ipv6_hdr(skb)->daddr.in6_u.u6_addr32[1] ^
ipv6_hdr(skb)->daddr.in6_u.u6_addr32[2] ^
ipv6_hdr(skb)->daddr.in6_u.u6_addr32[3];
} else {
Expand Down
20 changes: 20 additions & 0 deletions test/unit_homa_qdisc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -929,6 +929,26 @@ TEST_F(homa_qdisc, homa_qdisc_can_bypass__test_address_and_ports)

kfree_skb(skb);
}
TEST_F(homa_qdisc, homa_qdisc_can_bypass__ipv6_address_uses_all_words)
{
struct in6_addr daddr = unit_get_in_addr("1:2:3::4");
struct homa_qdisc *q = init_qdisc(self->qdiscs[3]);
struct sk_buff *skb;

mock_ipv6 = true;
skb = mock_tcp_skb(&self->addr, &daddr, 4000, 100);
homa_qdisc_defer_tcp(q, skb);

/* Same flow: must not bypass the deferred packet. */
skb = mock_tcp_skb(&self->addr, &daddr, 5000, 200);
EXPECT_EQ(0, homa_qdisc_can_bypass(skb, q));

/* Address differs only in the second 32-bit word. */
ipv6_hdr(skb)->daddr = unit_get_in_addr("1:2:5::4");
EXPECT_EQ(1, homa_qdisc_can_bypass(skb, q));

kfree_skb(skb);
}
TEST_F(homa_qdisc, homa_qdisc_can_bypass__multiple_packets_in_list)
{
struct homa_qdisc *q = init_qdisc(self->qdiscs[3]);
Expand Down