Repository navigation
Conversation
PoliNetworkOrg/backend#97 drops tg_audit_log.admin_id, after copying it into actor_tg_id, and the anonymous path agent mode relied on. The audit actor now comes from actorTgId only, and the agent-mode docs say the backend refuses its calls.
The backend no longer copies PoliNetwork Auth roles and the Microsoft 365 Soci group into the register: it reads them, and Telegram group admins through the bot, on every operation. Being in the Soci group is being a member, and the register keeps only history and People's own data.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
Remove Telegram group columns, join-request actions and census group selections. Keep the Capo area scoped to assigned active admins and update contracts, fixtures, docs and regression tests. BREAKING CHANGE: Requires the matching backend People contract without Telegram group assignments and join-request procedures.
BIA3IA
changed the title
Require only first and last name, with optional contacts, team memberships and admin status. Show preliminary Auth identities and Master-approved linking reviews; keep profile census fields optional and document the cross-service flow.
BIA3IA
changed the title
…urce-docs # Conflicts: # src/features/people/people.contract.ts
My area renders the backend's `awaiting-approval` state: the matched record when the match is verified, otherwise a notice that the sign-in is being checked, and no "Ask to be added". Agent mode previews it with `AGENT_PERSON=awaiting:P-…`.
- Linking page resolves `identity-match` reviews (link or decline), the matches HR confirms: a record that carries roles, a role holder matched by Telegram ID or a non-PoliNetwork address, or a Telegram username. - `docs/people/linking.md` describes the single matching rule, the outcome policy, the decisions taken and what changed; the contract and pre-registration docs point to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align People with PoliNetwork Auth as the source of admin and team roles, and Microsoft 365 as the source of association membership. This follows #132 and requires PoliNetworkOrg/backend#99.
Validation:
pnpm check,pnpm typecheck,pnpm test, andpnpm buildpassed. 204 tests passed and 3 were skipped; check reports 28 warnings. Browser navigation opened Admins in agent mode, but snapshot and evaluate timed out, so visual verification is incomplete.BREAKING CHANGE: Requires the matching People backend contract without Telegram group assignments, join-request procedures and census
keepGroups. Coordinate deployment with backend#99.Integration verification
Includes current main, the updated #132 parent and legacy cleanup #135. Conflicts in the Capo page and contract were resolved by retaining the Auth-based admin model: no Telegram group fields or join requests are restored. Check, typecheck, all dashboard tests and build passed for this combined tree. Merge this PR into #132 before merging #132 into main; #135 must reach main before backend#97. Backend#99 and the final People dashboard require coordinated deployment.
People before first login
New manual People creation requires only first and last name, with optional contact details, initial teams and admin status. The person and roles are created in Auth, even before login. Census details are optional on profile editing and are not required for creation; census submission/import validation remains strict.
Auth supplies verified-email/Telegram matches, name-only hints and conflict proposals to Linking. A Master Admin approves the link in Auth before the actual account receives the preliminary person's roles. Stable registration IDs preserve the People record/history across approval and restarts; declared Telegram contacts never cause automatic linking. Existing historical records/imports are not automatically migrated.
Requires the expanded Auth#75 (on Auth#73), including migration 0024, deployed first. No new dependency on the Telegram bot or legacy anonymous access is introduced.
Validation for this addition: check, typecheck, test and build passed; 205 tests passed and 3 were skipped (28 lint warnings). Browser verification created a person using only names plus IT, then checked the preliminary record at desktop and 390px with no horizontal overflow. Agent mode exercises the interface; actual Auth creation/linking was tested separately against disposable PostgreSQL. Design and rollout: docs/people/pre-registration.md.