Repository navigation
feat(people): register people before login and expose role assignment dates - #75
Merged
Merged
Conversation
People reads who holds its bound roles from GET /api/internal/people-roles on every operation instead of keeping a copy, so it needs this IdP to say when each role started: since maps every held bound role to the date (YYYY-MM-DD, UTC) of the earliest assignment that confers it, directly or through a parent role.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
Keep preliminary identities and declared contacts in Auth without credentials or provider accounts. Offer verified identity and name-only review proposals; require Master Admin approval to transfer current bound roles to a real login account while preserving provider accounts and existing roles. Add the preliminary-person migration and idempotent creation, contact editing and linking commands, with PostgreSQL and matching coverage.
BIA3IA
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
People can register a person in Auth before their first login, using only first and last name, optional contacts, and initial bound admin/team roles. Auth remains the authority for identity details and role assignments. This extends #73 and supports PoliNetworkOrg/backend#99 and PoliNetworkOrg/admin#136.
0024_people_registration.sqlstores declared contacts separately from verified provider evidence. The preliminary Auth subject has no credentials, provider accounts or sessions, and is excluded from the login-account/signing picker.create-person,update-personandlink-personcommands. Creation/contact editing requireadmin:accessandpeople:write; every role assignment still passes the original delegation checks. Reused IDs with changed input are refused.users[].since, the earliest assignment date conferring each held bound role, including inheritance.Validation: check, typecheck, all tests and production build/bundle validation passed. 352 tests passed and 117 were skipped, with the People role PostgreSQL suite enabled on a disposable migrated database. New coverage checks contact matching, ambiguity, no pre-login provider account, idempotent creation, rejected non-Master linking, Master approval and canonical directory identity.
Merge into #73 first. Deploy Auth and apply migration 0024 before the matching backend/dashboard feature. Keep the People role bindings and backend
idp:people:rolesscope configured. Other integration suites requiring their own external configuration remain skipped; no production mutation or real-provider sign-in was performed.