Repository navigation
test(dag-viewer): update three viewer assertions the planner's newer plans made stale - #892
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Three DAG viewer tests fail on main against main's own committed example documents (
cd tools/dag-viewer && python3 -m unittest test_viewer). The documents are current (cargo test -p asap-devtools --test stage_pipelinepasses); the assertions still describe plans from before #855 and #884.What
Updates three assertions in
tools/dag-viewer/test_viewer.pyto the plans the planner now selects. No viewer code or example document changes.test_doc_parameter_opens_one_document_with_the_selected_planL1P3-m1, fromL3(shared Scan and TimeRange for Q1 and Q2)test_each_node_lists_the_queries_reaching_it_and_shared_nodes_say_sotest_search_header_groups_discards_by_causecomponents: []andsearched_as_one: not_in_joint_space: #884 finds components, but their combined plan is not in the joint search space (exact top-k reuse is not combined with panes), so the workload is searched as one (same plan cost, 1.576e-6)How
from_logicaland checks lane 1 shows it (pinned toL3), instead of a hard-codedL1.searched_as_one: not_in_joint_spaceand checks that no component count is shown when the workload is searched as one. The component line itself stays covered byDefaultSearchTests.test_header_names_the_search_and_its_components(two queries over two metrics).Key code interfaces added / modified
None (tests only).
Major algorithm changes
None.
Before this PR
python3 -m unittest test_vieweron main: 2 failures, 1 error.After this PR
The viewer's Python tests pass on main's committed documents.
Verification
At 134f600:
python3 -m unittest test_viewer test_server(with a builtstage_pipeline, so nothing skipped): 94 tests OK.node stages.test.mjs(Node 22): 0 failures.cargo test -p asap-devtools --test stage_pipeline: 36 passed, including the check that committed examples are current.