Skip to content

test(dag-viewer): update three viewer assertions the planner's newer plans made stale #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zzylol merged 2 commits into from
Oct 22, 2026
Merged

test(dag-viewer): update three viewer assertions the planner's newer plans made stale #892

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c28fc6
test(dag-viewer): update three viewer assertions the planner's newer …
zzylol Oct 22, 2026
134f600
test(dag-viewer): state why seed-862 is searched as one component
zzylol Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions tools/dag-viewer/test_viewer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,10 @@ def test_queries_show_recurrence_and_predictability(self):
def test_search_header_groups_discards_by_cause(self):
text = self.js.call("searchText", self.doc)
self.assertIn("default search · ", text)
self.assertIn("2 independent components searched separately", text)
# The components' combined plan is not in the joint search space, so
# the workload is searched as one and the header has no component count.
self.assertEqual(self.doc["stage3_plan_selection"]["search"]["searched_as_one"], "not_in_joint_space")
self.assertNotIn("independent components", text)
self.assertIn("discarded before composition: no accuracy guarantee ×7 (q3, q4, q5, q6, q7) · ", text)
self.assertIn("Stage 2 assignments skipped: they scan raw data at query time", text)

Expand Down Expand Up @@ -652,13 +655,13 @@ def test_an_expanded_chain_shows_each_pane_with_its_time_range_shift_and_window(

def test_each_node_lists_the_queries_reaching_it_and_shared_nodes_say_so(self):
elements = self.elements()
# The quantile queries q3-q5 share one scan, one pane chain of
# DDSketches; q3 and q4 also share its merge.
# The quantile queries q3-q5 read the same 100 s window of one
# per-series DDSketch pane chain, so they share its scan and merge.
scans = [e for e in lane_nodes(elements) if e["data"]["kind"] == "Scan"]
shared = next(e for e in scans if e["data"]["reachedBy"] == ["q3", "q4", "q5"])
self.assertIn("shared ×3", shared["data"]["label"])
merge = next(e for e in lane_nodes(elements) if e["data"]["kind"] == "SummaryMerge" and e["data"]["reachedBy"] == ["q3", "q4"])
self.assertIn("shared ×2", merge["data"]["label"])
merge = next(e for e in lane_nodes(elements) if e["data"]["kind"] == "SummaryMerge" and e["data"]["reachedBy"] == ["q3", "q4", "q5"])
self.assertIn("shared ×3", merge["data"]["label"])
root = self.node(elements, f"n{self.dag['roots'][8]}")
self.assertEqual(root["data"]["reachedBy"], ["q9"])
self.assertNotIn("shared", root["data"]["label"])
Expand Down Expand Up @@ -846,7 +849,10 @@ def test_doc_parameter_opens_one_document_with_the_selected_plan(self):
self.assertIn("Candidates per stage", self.text(js, "counts"))
self.assertIn("✓ selected", self.text(js, "lane2-meta"))
self.assertEqual(js.eval("__els.pick2.value"), selected)
self.assertEqual(js.eval("__els.pick1.value"), "L1")
# Lane 1 shows the Stage 1 candidate the selected plan came from.
from_logical = next(c["from_logical"] for c in example1()["stage2_physical_asap_optimization"]["candidates"] if c["id"] == selected)
self.assertEqual(from_logical, "L3")
self.assertEqual(js.eval("__els.pick1.value"), from_logical)
combinations = example1()["stage1_logical_asap_optimization"]["combinations"]
rank_meta = js.eval("__els['rank-meta'].textContent")
self.assertIn(f"{combinations} candidates", rank_meta)
Expand Down
Loading