Repository navigation
docs: correct the config-fallback comments on the NNLS warm-start settings (#506) - #504
Merged
Merged
Conversation
…tings (#506) The `except KeyError` comments on `nnls_warm_start_memo` and `nnls_warm_start_error_tolerance` claimed a workspace `general.yaml` shadows autoarray's, making the hard-coded fallback the production default. In practice a workspace `general.yaml` omits these keys and autoconf's config-path list falls through to autoarray's packaged value (measured `True` / `1.5` from autolens_workspace). The fallback fires only when the workspace config is the sole config path (isolated test configs push one dir) and returns the same packaged value, so both routes resolve identically. Comments only; no code, behaviour or test changes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XySQZP6Npj4adZMkYZ96Bo
This was referenced Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comment-only reword of the config-fallback explanation on the two NNLS warm-start settings,
nnls_warm_start_memoandnnls_warm_start_error_tolerance.The
except KeyErrorcomments claimed that a workspacegeneral.yaml"shadows" autoarray's, sothe hard-coded fallback "is the production default". That overstates what happens. A workspace
general.yamlnormally omits these keys, andautonerves/autoconf's config-path list simply fallsthrough to autoarray's packaged
general.yaml— measured fromautolens_workspace, the resolvedvalues are
Trueand1.5, read from the packaged config, never from the fallback. TheKeyErrorbranch fires only when the workspace config is the sole config path (isolated test configs push a
single directory), and it returns the same packaged default, so both routes resolve identically.
The reworded comments say exactly that. No behaviour, code or test changes; the
__init__docstringentries for both parameters already stated the accurate "
None(default) reads the packaged value"and were left untouched.
API Changes
None — internal changes only.
Test Plan
Additionally verified empirically from
autolens_workspacethat the workspacegeneral.yamlcarriesneither key and that
conf.instance["general"]["inversion"][...]resolves toTrue/1.5fromautoarray's packaged config.
Closes nothing; part of PyAutoLabs/autolens_workspace#506.
Generated by the PyAutoLabs agent workflow.