Skip to content

test: drop stray dynamic_delta/delta kwargs passed to DynestyStatic - #1695

Merged
Jammy2211 merged 1 commit into
mainfrom
feature/search-ext-kwarg-typos
Oct 15, 2026
Merged

Jammy2211 merged 1 commit into
mainfrom
feature/search-ext-kwarg-typos

Conversation

@Jammy2211

Copy link
Copy Markdown
Collaborator

Summary

test_autofit/graphical/hierarchical/test_optimise.py passed dynamic_delta=False, delta=0.1 to af.DynestyStatic. Neither is a DynestyStatic argument; they were always swallowed by **kwargs, and since A0b (#1672) they log an unknown-keyword WARNING. This drops them (af.DynestyStatic(maxcall=25)). Test-only change; no library source touched.

First of three PRs for #1693 (PyAutoFit → autofit_workspace → autofit_workspace_test). pending-release: PyAutoFit applies to this PR.

API Changes

None — test-only change.

Test Plan

  • pytest test_autofit/graphical/hierarchical/test_optimise.py — 2 passed
  • pytest test_autofit/ -x — 3812 passed, 1 skipped
  • Witness: af.DynestyStatic(maxcall=25, dynamic_delta=False, delta=0.1) logs DynestyStatic received the unknown keyword argument 'dynamic_delta' and 'delta'; af.DynestyStatic(maxcall=25) logs no WARNING.

Validation checklist (--auto run — plan was not pre-approved)

  • Effective level: safe (header: safe, Consequence: judge)
  • Plan: on the issue (fix: search kwarg typos silently ignored in workspace scripts and a graphical test #1693), written at start, unmodified since
  • Gate: tests 3812 passed / 1 skipped (full test_autofit/), target file 2/2 · smoke n/a for this repo (workspace scripts witnessed on the workspace PRs) · review: one independent Opus round — in-scope diff correct; FINDINGS were all missed occurrences of the same typos in workspace files outside fix: search kwarg typos silently ignored in workspace scripts and a graphical test #1693's listed scope (deferred as follow-up, listed on the autofit_workspace / autofit_workspace_test PRs) · Heart RED under the development-only override below
  • Witness: as Test Plan above
  • Human: plan sound in hindsight?
  • Human: diff matches plan (no scope creep)?
  • Human: merge, amend, or reject — then log the outcome

Heart RED — development-only override (quoted from #1693)

Heart at the door: Heart: RED — Release RED; monitoring RED · 10/100 · 415 unresolved; [red] release validation FAILED (stage integrate); [red] PyAutoHands/workflows/Python Version Matrix: failure; [red] PyAutoHeart/workflows/Release Integrate: failure; [red] PyAutoMind/workflows/Lifecycle Drift: failure (cleared 2026-10-15 evening); [red] PyAutoArray/Tests: red; [red] autofit_workspace_test/Smoke Tests: red; [red] autogalaxy_workspace_test/Smoke Tests: red; [red] autolens_workspace_test/Smoke Tests: red; [red] Release validation: NOT release_ready; [red] Worktree drift; [red] autolens_inference: red; [red] autolens_profiling: red; [red] euclid_strong_lens_modeling_pipeline: red. Live human in session 6ffb59e9 answered AskUserQuestion "Yes, override for development (Recommended)" on 2026-10-15 for this launch. Permitted: commit, push, PR-open. Merge is a separate human act; this never reaches a release.

Closes #1693

🤖 Generated with Claude Code

DynestyStatic never consumed these; since A0b (#1672) they log an
unknown-keyword warning.

Refs #1693

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Jammy2211

Copy link
Copy Markdown
Collaborator Author

@Jammy2211
Jammy2211 merged commit 7f36e16 into main Oct 15, 2026
3 checks passed
@Jammy2211
Jammy2211 deleted the feature/search-ext-kwarg-typos branch October 15, 2026 17:53
@Jammy2211 Jammy2211 removed the pending-release PR queued for the next release build label Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: search kwarg typos silently ignored in workspace scripts and a graphical test

1 participant