Repository navigation
test: drop stray dynamic_delta/delta kwargs passed to DynestyStatic - #1695
Merged
Merged
Conversation
Collaborator
Author
|
Workspace PRs: PyAutoLabs/autofit_workspace#170 · PyAutoLabs/autofit_workspace_test#112 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_autofit/graphical/hierarchical/test_optimise.pypasseddynamic_delta=False, delta=0.1toaf.DynestyStatic. Neither is a DynestyStatic argument; they were always swallowed by**kwargs, and since A0b (#1672) they log an unknown-keyword WARNING. This drops them (af.DynestyStatic(maxcall=25)). Test-only change; no library source touched.First of three PRs for #1693 (PyAutoFit → autofit_workspace → autofit_workspace_test).
pending-release: PyAutoFitapplies to this PR.API Changes
None — test-only change.
Test Plan
pytest test_autofit/graphical/hierarchical/test_optimise.py— 2 passedpytest test_autofit/ -x— 3812 passed, 1 skippedaf.DynestyStatic(maxcall=25, dynamic_delta=False, delta=0.1)logsDynestyStatic received the unknown keyword argument 'dynamic_delta'and'delta';af.DynestyStatic(maxcall=25)logs no WARNING.Validation checklist (--auto run — plan was not pre-approved)
test_autofit/), target file 2/2 · smoke n/a for this repo (workspace scripts witnessed on the workspace PRs) · review: one independent Opus round — in-scope diff correct; FINDINGS were all missed occurrences of the same typos in workspace files outside fix: search kwarg typos silently ignored in workspace scripts and a graphical test #1693's listed scope (deferred as follow-up, listed on the autofit_workspace / autofit_workspace_test PRs) · Heart RED under the development-only override belowHeart RED — development-only override (quoted from #1693)
Closes #1693
🤖 Generated with Claude Code