Repository navigation
fix: search kwarg typos in searches/mcmc.py and nest.py - #170
Merged
Merged
Conversation
auto_correlations_settings -> auto_correlation_settings (Emcee, Zeus) and nlive -> nlive_init (DynestyDynamic); both were silently ignored. Notebooks regenerated. Refs PyAutoLabs/PyAutoFit#1693 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
3 of 6 tasks
auto_correlations_settings -> auto_correlation_settings (Emcee, Zeus) and nlive -> nlive_init (DynestyDynamic). Notebook regenerated. Refs PyAutoLabs/PyAutoFit#1693 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two search examples passed constructor kwargs that were always silently swallowed by
**kwargs, so the settings shown to users never applied. Since A0b (PyAutoLabs/PyAutoFit#1672, released) each logs an unknown-keyword WARNING. Argument names checked withinspect.signatureagainst released autofit 2026.10.12.1.auto_correlations_settings=→auto_correlation_settings=(Emcee, Zeus).nlive=50→nlive_init=50onaf.DynestyDynamic(its constructor takesnlive_init, default 500). Behaviour note: outside test mode the nest.py DynestyDynamic example now really runs with 50 initial live points instead of the 500 default it silently used. (cookbooks/search.pyonly constructs that search and never fits it, so it has no runtime change.) The Emcee/Zeus values match theAutoCorrelationsSettingsdefaults, so their results don't change.Notebooks regenerated with
PyAutoHands/autohands/generate.py autofit; only the touched cells differ. (The generator also rewrotenotebooks/searches/README.mdwith unrelated roster drift; I reverted that to stay in scope.)Scripts Changed
scripts/searches/mcmc.py—auto_correlation_settingsspelling (Emcee, Zeus)scripts/searches/nest.py—nlive→nlive_initforDynestyDynamicscripts/cookbooks/search.py— same two fixes (auto_correlation_settingsfor Emcee/Zeus;nlive_initforDynestyDynamic), found in reviewnotebooks/searches/mcmc.ipynb,notebooks/searches/nest.ipynb,notebooks/cookbooks/search.ipynb— regeneratedUpstream PR
PyAutoLabs/PyAutoFit#1695 — library-first: merge that one before this PR. The script fixes run fine on the released library either way.
Test Plan
Witness,
PYAUTO_TEST_MODE=1against released autofit 2026.10.12.1 (and again against the PyAutoFit main source):searches/mcmc.py— before:Emcee received the unknown keyword argument 'auto_correlations_settings'(also Zeus); after: exit 0, unknown-keyword warnings: 0 (the only WARNINGs left are TEST MODE notices)searches/nest.py— before:DynestyDynamic received the unknown keyword argument 'nlive'; after: exit 0, unknown-keyword warnings: 0cookbooks/search.py— before:Emcee/Zeus'auto_correlations_settings'andDynestyDynamic'nlive'warnings (3); after: exit 0, unknown-keyword warnings: 0Validation checklist (--auto run — plan was not pre-approved)
smoke_tests.txt) · review: one independent Opus round — in-scope diff correct; its findings (missed copies incookbooks/search.py) were fixed in this PR under a scope extension from the coordinator; the second short Opus round on that diff: CLEAN · Heart RED under the development-only override belowHeart RED — development-only override (quoted from #1693)
🤖 Generated with Claude Code