Repository navigation
feat: solved parameters on linear profiles + PointSolved; model cookbook figures (PyAutoLens#736) - #616
Merged
Conversation
…k figures (PyAutoLens#736) Model figures phase 3. LightProfileLinear declares intensity and PointSolved declares centre through PyAutoFit's new `__solved_parameters__` protocol, so model figures draw them as dashed `solved` pills instead of omitting them; Basis deliberately declares nothing (its members carry the solved amplitudes). Real-class semantics tests cover linear intensity, Basis, PointSolved, Delaunay's missing areas_factor and free/fixed redshift. The model cookbook docs page is re-synced to the workspace script and gains a figure per stage plus a "Reading the figure" note; overview_3 gains the MGE model figure. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0178yLU9v19GtACcRPFggjGa
3 of 4 tasks
Collaborator
Author
This was referenced Sep 11, 2026
Merged
Collaborator
Author
|
Workspace PR: PyAutoLabs/autogalaxy_workspace#240 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PyAutoGalaxy half of model-figures phase 3 (PyAutoLens#736). Declares, through PyAutoFit's new
__solved_parameters__class-attribute protocol (PyAutoFit sibling PR), the quantities a fit solves rather than samples:LightProfileLinear.__solved_parameters__ = ("intensity",)(inherited by everylp_linear.*profile) andPointSolved.__solved_parameters__ = ("centre",).Basisdeclares nothing — it has no model-level amplitude; the solved intensities belong to its linear members (docstring says so). Model figures now showintensity · solved/centre · solveddashed pills where the picture used to imply "no amplitude" or an empty component.Real-class semantics tests (
test_autogalaxy/profiles/test_model_figure_semantics.py, 12): linear intensity solved vs standard intensity free; Basis has no amplitude and its 3 members collapse to a plate whoserepeatsline readsintensity solved;PointSolvedone solved row,Pointfree tuple;af.Model(ag.mesh.Delaunay)leaves exactlyareas_factorasmissing(pixelsis an R7 fixed row from theintannotation,zeroed_pixelstakes its default — not the three-missing the plan assumed);Pixelizationshowsreconstruction · solved; freeRedshiftis a pill on the galaxy card, fixed redshift is theredshift = 0.5subtitle.Docs:
docs/general/model_cookbook.mdre-synced toautogalaxy_workspace/scripts/guides/modeling/cookbook.py(ag.lp_linear.*), a model figure after each of the 6 stages, and a "Reading the figure" paragraph (map vs legend; background tint follows nesting depth only and is decorative);docs/overview/overview_3_features.mdgains the MGE model figure. PNGs underdocs/general/images/model_cookbook/withmake_figures.py.API Changes
Added class attributes
LightProfileLinear.__solved_parameters__andPointSolved.__solved_parameters__(consumed by PyAutoFit's model figures). No behaviour change. See full details below.Test Plan
test_autogalaxy/profiles/test_model_figure_semantics.py12 passed;test_autogalaxy/profiles756 passed (serial, task worktree with the sibling PyAutoFit branch).lib-testschecks out the same-named PyAutoFit / PyAutoArray branches).Full API Changes (for automation & release notes)
Added
autogalaxy.profiles.light.linear.abstract.LightProfileLinear.__solved_parameters__ = ("intensity",)autogalaxy.profiles.point_sources.PointSolved.__solved_parameters__ = ("centre",)Migration
autofit>=the first release carrying the protocol; the attributes are harmless on older PyAutoFit.Generated by the PyAutoLabs agent workflow.
🤖 Generated with Claude Code
https://claude.ai/code/session_0178yLU9v19GtACcRPFggjGa