Repository navigation
feat: model figures phase 3 — real-class lens acceptance + cookbook/overview figures (#736) - #737
Merged
Merged
Conversation
…ew figures (PyAutoLens#736) Model figures phase 3. test_autolens/model_figure builds the epic's three acceptance models with the real classes (simple lens; MGE 2x30 linear Gaussians + Delaunay/ConstantSplit pixelized source; group scale with eight extra galaxies) and asserts the structural invariants: two "30 components" plates split on ell_comps with intensity solved, reconstruction solved, areas_factor missing, per-galaxy fixed centres varying by member. The model cookbook docs page is re-synced to the workspace script and gains a figure per stage, a Redshift Free model, a Solved Parameters section and a "Reading the Figure" note (correspondence contract, the plate-vs-model.info grouping difference, tint = nesting depth); overview_3 gains MGE, pixelization and point-source model figures. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0178yLU9v19GtACcRPFggjGa
Collaborator
Author
…t config (PyAutoLens#736) autolens_workspace configures it as a constant 0.5, so the same model drawn from the workspace shows a fixed pill rather than the red missing pill. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0178yLU9v19GtACcRPFggjGa
Merged
2 of 3 tasks
Collaborator
Author
|
Workspace PRs: PyAutoLabs/autolens_workspace#541 · PyAutoLabs/autogalaxy_workspace#240 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PyAutoLens half of model-figures phase 3 (issue #736; protocol in the PyAutoFit sibling PR, declarations in the PyAutoArray and PyAutoGalaxy sibling PRs). This PR renders the epic's three lens acceptance models with the real classes and puts model figures into the lens documentation.
test_autolens/model_figure/(19 tests): (a) simple lens — six model cards inmodel.infoorder; (b) MGE 2×30lp_linear.Gaussianin twoBasiscomponents +Pixelization(Delaunay(pixels=500, zeroed_pixels=0), ConstantSplit)source — two30 componentsplates split onell_comps,centreshared across the group,intensity · solvedon every member,reconstruction · solved,areas_factor · missing, 6 shared priors; (e) group scale with eight synthetic extra-galaxy centres — one plate of 8 withcentre · fixed, varies by memberand independentsigma. Counts pinned as measured with# epic targetcomments (the real pixelized source has 1 sampled scalar, so (b) reports 14 unique sampled scalars where the phase-1 double's Sersic source gave 16). PNG widths ≤ 1400 px, layout dict deterministic.Docs:
docs/general/model_cookbook.mdre-synced toautolens_workspace/scripts/guides/modeling/cookbook.py(al.lp_linear.*, regeneratedmodel.infoblock), a model figure after every stage, the Redshift Free stage now builds its model, a new## Solved Parameterssection (linearintensity, pixelizationreconstruction,PointSolved.centreare solved during fitting and are additional information absent frommodel.info; aDelaunaymesh with no prior config showsareas_factor · missing), and## Reading the Figure(map vs legend; the correspondence contract; the plate-vs-model.infogrouping paragraph from the epic; background tint follows nesting depth only). The script-less "Multi Galaxy, Group and Cluster Models" section now points atgroup/modeling.pywith the group figure.docs/overview/overview_3_features.mdgains MGE, pixelization and point-source model figures. Evidence PNGs underdocs/general/images/model_cookbook/anddocs/overview/images/overview_3/withmake_figures.py.Two things the figures exposed, documented rather than patched here: a relation on one component of a tuple (
mass.centre.centre_0 = bulge.centre.centre_0 + 0.1) is carried by the spec but not yet annotated on the tuple pill (phase-2 presentation follow-up); andcookbook.py:247setssource.effective_radiuson the Galaxy rather thansource.bulge, adding a stray free parameter — fixed in the autolens_workspace follow-up PR.API Changes
None — tests and docs only. See full details below.
Test Plan
test_autolens/model_figure19 passed;test_autolens/point162 passed + 1 xfail (serial, task worktree with the sibling branches).lib-testschecks out the same-named PyAutoFit / PyAutoArray / PyAutoGalaxy branches).Full API Changes (for automation & release notes)
Added
Migration
Generated by the PyAutoLabs agent workflow.
🤖 Generated with Claude Code
https://claude.ai/code/session_0178yLU9v19GtACcRPFggjGa