Repository navigation
feat: keep dataset-only image_with_points.png; after-fit figure → fit_image_with_points.png - #782
Merged
Merged
Conversation
… as fit_image_with_points.png (#781) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Workspace PR: PyAutoLabs/autolens_workspace#592 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The point visualizer wrote both of its image figures under
image_with_points.png. The after-fit figure overwrote the dataset-only one written before the fit. The after-fit figure is now saved asfit_image_with_points.png, so both are kept:image_with_points.png: the observed image with the observed positions only (no model, no critical curves). Use it to display the data before lens modeling.fit_image_with_points.png: adds model positions (image-plane fits only) and critical curves. Titled "… Fit Image With Points".Closes #781 (library part). Follow-up to #780.
API Changes
plot_image_with_pointssavesfit_image_with_points.pngwhen afitis passed; it savesimage_with_points.pngwhen no fit is passed.plots.yamlfit keyfit_point_dataset.image_with_pointsis renamed tofit_point_dataset.fit_image_with_points. Both were added in feat: overlay point-source positions on a dataset image #780, which is unreleased, so no user config is affected.See full details below.
Test Plan
pytest test_autolens/: 843 passed, 1 xfailed.image_with_points.pngfit_image_with_points.pngvisualize_before_fit+visualize, with and withoutquick_updateReadiness
Heart readiness was YELLOW (score 85) at ship time:
Explicitly acknowledged by the human on 2026-10-21. Neither reason involves this change.
Full API Changes (for automation & release notes)
Changed
autolens.plot.plot_image_with_points(..., fit=<fit>)now writesfit_image_with_points.png(wasimage_with_points.png). Without a fit it still writesimage_with_points.png.plots.yaml:fit_point_dataset.image_with_points→fit_point_dataset.fit_image_with_points.Migration
Generated by the PyAutoLabs agent workflow.
🤖 Generated with Claude Code