Skip to content

feat: keep dataset-only image_with_points.png; after-fit figure → fit_image_with_points.png - #782

Merged
Jammy2211 merged 1 commit into
mainfrom
feature/point-image-fit-filename
Oct 21, 2026
Merged

Jammy2211 merged 1 commit into
mainfrom
feature/point-image-fit-filename

Conversation

@Jammy2211

Copy link
Copy Markdown
Collaborator

Summary

The point visualizer wrote both of its image figures under image_with_points.png. The after-fit figure overwrote the dataset-only one written before the fit. The after-fit figure is now saved as fit_image_with_points.png, so both are kept:

  • image_with_points.png: the observed image with the observed positions only (no model, no critical curves). Use it to display the data before lens modeling.
  • fit_image_with_points.png: adds model positions (image-plane fits only) and critical curves. Titled "… Fit Image With Points".

Closes #781 (library part). Follow-up to #780.

API Changes

  • plot_image_with_points saves fit_image_with_points.png when a fit is passed; it saves image_with_points.png when no fit is passed.
  • The plots.yaml fit key fit_point_dataset.image_with_points is renamed to fit_point_dataset.fit_image_with_points. Both were added in feat: overlay point-source positions on a dataset image #780, which is unreleased, so no user config is affected.
    See full details below.

Test Plan

  • pytest test_autolens/: 843 passed, 1 xfailed.
  • New tests:
    • before-fit writes only image_with_points.png
    • after-fit writes fit_image_with_points.png
    • both coexist after visualize_before_fit + visualize, with and without quick_update
    • the dataset-only call draws no Model scatter and no lines

Readiness

Heart readiness was YELLOW (score 85) at ship time:

  • manifest drift: workspace checkouts (manifest ↔ disk) — 1 mismatch(es) vs PyAutoMind/repos.yaml
  • release validation stale: source moved since rehearsal (PyAutoArray)

Explicitly acknowledged by the human on 2026-10-21. Neither reason involves this change.

Full API Changes (for automation & release notes)

Changed

  • autolens.plot.plot_image_with_points(..., fit=<fit>) now writes fit_image_with_points.png (was image_with_points.png). Without a fit it still writes image_with_points.png.
  • plots.yaml: fit_point_dataset.image_with_points → fit_point_dataset.fit_image_with_points.

Migration

Generated by the PyAutoLabs agent workflow.

🤖 Generated with Claude Code

… as fit_image_with_points.png (#781)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Jammy2211

Copy link
Copy Markdown
Collaborator Author

Workspace PR: PyAutoLabs/autolens_workspace#592
Visualization PR: PyAutoLabs/autolens_visualization#7

@Jammy2211
Jammy2211 merged commit f98a021 into main Oct 21, 2026
4 checks passed
@Jammy2211
Jammy2211 deleted the feature/point-image-fit-filename branch October 21, 2026 11:14
@Jammy2211 Jammy2211 removed the pending-release PR queued for the next release build label Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: keep dataset-only image_with_points.png; after-fit figure → fit_image_with_points.png

1 participant