Repository navigation
midiEngine: say on the status line when the sound can't start - #40
Merged
Merged
Conversation
With no SoundFont, or a sampler that fails to open, a detected keyboard played nothing and the status line only named the keyboard, so it looked like a bug in the keys. The status line now shows the reason (and keeps showing it when a device appears) until the sound is running. Live keys were never gated on a MIDI file: the port is read whether or not a file is loaded. Checked on a GIGA: with audioeffects missing the status line and face both read the error; with it present, 109 files list from /sd/midi, GeneralUser GS opens and a chord from the keys, with no file playing, moves the DAC pin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A keyboard that is detected but silent looked like broken keys: the status line named the keyboard even when no SoundFont (or no sampler) had started, so there was nothing playing to hear. The status line now shows the reason until the sound runs, and the face already carries it.
Live keys never depended on a MIDI file; the port is read whether or not one is loaded. Checked on a GIGA R1 with a USB drive as /sd: 109 files list, GeneralUser GS opens, a file plays and the DAC pin swings with it (rms 2316 against 13 stopped), and a chord fed through the same path with no file playing moves it too (rms 1810). With audioeffects removed the status line and face both read the error. Not checked: keys played by hand on the Donner.