Skip to content

midiEngine: say on the status line when the sound can't start #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdbarnett merged 1 commit into from
Nov 7, 2026
Merged

midiEngine: say on the status line when the sound can't start #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions apps/midiengine/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ def find_banks():
found = banks.candidates(banks.folders(desktop), banks.getenv("SOUNDFONT"))
if not found:
st["error"] = ("No SoundFont. Put a .sf2 in ~/soundfonts, or set SOUNDFONT to one." if desktop else
"No SoundFont. Put a .sf2 in %s or %s." % (banks.SD_SOUNDFONTS, banks.FLASH_SOUNDFONTS))
"No SoundFont, so no sound. Put a .sf2 in %s or %s." % (banks.SD_SOUNDFONTS, banks.FLASH_SOUNDFONTS))
return None
return found

Expand Down Expand Up @@ -828,7 +828,8 @@ def setup(t):
st["midi"] = watch.text
st["midi_told"] = False
if watch.text:
status.set_text(watch.text)
# Without a bank the keys play nothing: say that, not just who is plugged in.
status.set_text(watch.text if st["module"] is not None or not st["error"] else st["error"])
elif st["port"] is not None:
status.set_text(st["midi"])
setup_timer.deinit()
Expand All @@ -852,6 +853,8 @@ def close():

scope.on_close(close)
found = find_banks()
if found is None and st["error"]:
status.set_text(st["error"]) # plain on the status line too: keys play nothing without a bank
if found is not None and len(found) == 1:
start_audio(found[0][0])
elif found:
Expand Down
Loading