Repository navigation
fix: nobody talks as if Aksel were still across the bay after he walks in - #48
Merged
Merged
Conversation
…s in Marit's row reads "Aksel walked in out of the dark" once AKSEL_WALKED_IN is set, and her arithmetic owns that the sum did not close. The supper line about the far side of the bay is swapped after the draw while Aksel is at the table, so TABLE_TALK keeps its length and order. Teo stops saying "don't ask me why" to someone he has already told, and the MARITS_ARITHMETIC and TEOS_NIGHTS texts no longer claim the sum or the nights still stand. Closes #47 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (PR #48, head on
Out-of-diff observation: This review was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lines that assumed the cook had crossed the bay, or that the count and the night hours still stood, are made true after the walk-in and the storm night (all five points of #47).
people.py, Marit: the row reads "Aksel walked in out of the dark. You knew he was out there." onceAKSEL_WALKED_INis set, instead of "I've been across the bay. I've met Aksel." HerherArithmeticsays "The sum was meant to close. It did not, and he came in out of the dark on the night it showed." after the walk-in, and keeps "The sum still closes." otherwise.scenes/galley.py: the supper line "Nobody talks about the far side of the bay..." is now the constantNOBODY_TALKS_ABOUT_THE_BAY. When it is drawn whilestate.akselAt == AKSEL_STATION,Galley.tableTalk()replaces it withAKSEL_AT_THE_TABLEafter the draw.TABLE_TALKkeeps its length and order, so a reloaded save hears the same suppers.people.py, Teo'safterTheDryNight: a player who already knowsTEOS_NIGHTShears "You know why; I told you." instead of "Don't ask me why. (You could. You don't.)".facts.py:MARITS_ARITHMETICnow ends "She meant the sum to close without anyone having to check it." andTEOS_NIGHTSis in the past tense ("From the night the plane left he ran the generator through the night..."). Fixed texts cannot branch, so both are rewritten to hold on any day.Every new gate reads a
flags.*constant, astate.knows(...)or astate.*property; none readsstate.day. Nostate.py, save-format or calendar change.Test plan
python3 -m pytest: 185 passed locallytests/test_people.py(Marit after the walk-in, Marit before it, Teo once told, both fact texts) andtests/test_scenes.py(the supper line with Aksel at the hut and at the station). With the source changes stashed, the three new people tests fail and the galley test fails at import. With them restored, all pass.tests/test_game.pyandtests/test_endings.pypass unmodified ("I've been across the bay"is still the row on every scripted route where Aksel did not walk in)black --checkcould not be run in this session's sandbox, and CI does not enforce it. Line lengths were checked by hand.Closes #47
Skipped this cycle: #18 is waiting on a story decision (see the comment there), and #40 would edit a comment in
state.py, which is on the do-not-auto-merge list. It is left for a separate PR that a human reviews.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson