Skip to content

[DO NOT MERGE] - Testing Kubernetes secrets (#434–#442), namespace chooser (#443, #444) and #423 on oasis staging - #468

Closed
yuechao-qin wants to merge 19 commits into
masterfrom
ycq/staging-integration-secrets-namespace
Closed

yuechao-qin wants to merge 19 commits into
masterfrom
ycq/staging-integration-secrets-namespace

Conversation

@yuechao-qin

Copy link
Copy Markdown
Collaborator

Do not merge. A test branch for oasis staging: it puts the Kubernetes secrets stack, the namespace chooser and #423 on one commit, so oasis staging can pin backend/ to it and exercise them together before any of them merges.

What is in it

master plus one merge of three branches:

Branch PRs
k8s-secrets-8-files #434, #435, #437, #438, #439, #440, #441, #442 — Kubernetes secrets
k8s-namespace-ignore-postprocessor #443, #444 — namespace chooser
ycq/do-not-print-resolved-input-argument-values #423 — resolved values kept out of error text

#467 (k8s-secrets-9-value-inputs) is left out: not reviewed yet.

Base

The base is master, so the diff is only the three branches. Oasis staging pins ab15742 today; everything in it is already on master (#396, #415 and #418 merged there), so this branch contains it: merging that commit back in changes no file.

Compared with that pin, staging also gains master's own commits since then — dependency bumps, #425, #447, #456 (drops Python 3.10; oasis runs 3.12) and #460.

Checks

Check Result
merge clean; one automatic three-way merge in kubernetes_launchers.py
files changed against master 7, exactly the files the three branches touch
the base is contained ✅
pytest 623 passed; the 22 tests/instrumentation/test_execution_tracing.py failures also fail on master
black --check ✅

yuechao-qin and others added 19 commits November 2, 2026 08:58
A dataclass prints every field in its generated repr, so interpolating an InputArgument into a launcher error message published the resolved secret to the log, the error reporter, the database and the execution-log API alike. repr=False on the value field removes it from all 19 of those messages at once, while leaving the field itself unchanged.
… Kubernetes Secret

Carries #431 unchanged on the current master; the import block conflict is resolved by keeping re, threading and time.
…env var name

Input names like api-key and api_key both become __TANGLE_SECRET_API_KEY; the second used to overwrite the first, so one input silently received the other's value. The launch now fails with LauncherError.
Kubernetes refuses Secret keys outside [-._a-zA-Z0-9], which Tangle secret names may use (e.g. "hf token"). The env var name is derived from the input name, always valid, and unique within the execution's own Secret, so the Secret and its secretKeyRef use it. Done here rather than earlier in the stack: with one Secret per user, keying by env var name would let two runs that share an input name overwrite each other's value.
@yuechao-qin
yuechao-qin requested a review from a team November 13, 2026 21:03
@yuechao-qin
yuechao-qin requested a review from Ark-kun as a code owner November 13, 2026 21:03


class NamespaceChooser(typing.Protocol):
def __call__(self, *, annotations: dict[str, str] | None = None) -> str: ...
@yuechao-qin
yuechao-qin marked this pull request as draft November 13, 2026 21:09
@yuechao-qin
yuechao-qin deleted the ycq/staging-integration-secrets-namespace branch November 16, 2026 06:55
@yuechao-qin
yuechao-qin restored the ycq/staging-integration-secrets-namespace branch November 18, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants