Repository navigation
[DO NOT MERGE] - Testing Kubernetes secrets (#434–#442), namespace chooser (#443, #444) and #423 on oasis staging - #468
Closed
yuechao-qin wants to merge 19 commits into
Closed
yuechao-qin wants to merge 19 commits into
yuechao-qin wants to merge 19 commits into
Conversation
A dataclass prints every field in its generated repr, so interpolating an InputArgument into a launcher error message published the resolved secret to the log, the error reporter, the database and the execution-log API alike. repr=False on the value field removes it from all 19 of those messages at once, while leaving the field itself unchanged.
… Kubernetes Secret Carries #431 unchanged on the current master; the import block conflict is resolved by keeping re, threading and time.
… Kubernetes Secret
…env var name Input names like api-key and api_key both become __TANGLE_SECRET_API_KEY; the second used to overwrite the first, so one input silently received the other's value. The launch now fails with LauncherError.
…ironment variable
… not the base64 data field
…he shared launcher base
…netes Secret on the Job launcher
…ion, owned by its Pod or Job
Kubernetes refuses Secret keys outside [-._a-zA-Z0-9], which Tangle secret names may use (e.g. "hf token"). The env var name is derived from the input name, always valid, and unique within the execution's own Secret, so the Secret and its secretKeyRef use it. Done here rather than earlier in the stack: with one Secret per user, keying by env var name would let two runs that share an input name overwrite each other's value.
… from the Kubernetes Secret
…ace through a hook
… by the pod post-processor
…r the Job transform hook
|
|
||
|
|
||
| class NamespaceChooser(typing.Protocol): | ||
| def __call__(self, *, annotations: dict[str, str] | None = None) -> str: ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge. A test branch for oasis staging: it puts the Kubernetes secrets stack, the namespace chooser and #423 on one commit, so oasis staging can pin
backend/to it and exercise them together before any of them merges.What is in it
masterplus one merge of three branches:k8s-secrets-8-filesk8s-namespace-ignore-postprocessorycq/do-not-print-resolved-input-argument-values#467 (
k8s-secrets-9-value-inputs) is left out: not reviewed yet.Base
The base is
master, so the diff is only the three branches. Oasis staging pinsab15742today; everything in it is already onmaster(#396, #415 and #418 merged there), so this branch contains it: merging that commit back in changes no file.Compared with that pin, staging also gains
master's own commits since then — dependency bumps, #425, #447, #456 (drops Python 3.10; oasis runs 3.12) and #460.Checks
kubernetes_launchers.pymasterpytesttests/instrumentation/test_execution_tracing.pyfailures also fail onmasterblack --check