Repository navigation
Read the Face-to-face waiting room in the window's language (#3114) - #3221
Conversation
The Face-to-face waiting room — the dialog's waiting step and the room overview's candidate card — drew its room number, QR hint, roster heading, alone line, Enter chat, Leave question and mine badges as bare English while the rest of the panel followed the window's language. This routes those draws through the tr() the file already carries, lands the 13 zh entries they need, and drops the 19 i18n baseline pins that held them. Written-by: Dev Fixes #3219 Part of #3114 Owner: Dev Reviewer: Reviewer Tier: T2 Docs-not-needed: the waiting room keeps its layout, state and server calls; this cut lands thirteen zh dictionary entries and routes existing literals through the tr() at plugins/social/client.js:1018, so docs/subsystems/social.md and docs/subsystems/core-client.md describe structure that does not change.
|
Verdict: PASS at c14d924 Ran at this tip: Numbers. New test at the tip 5/5/0; with only the new test kept and Tier. The one change outside this cut's range — Dictionary. All thirteen keys are present verbatim in Pins and baselines. Both baseline files lose only lines ( Scope and generated files. The base-to-tip tree differs in the 12 paths the PR lists and nothing else: CI at the tip. 19 check runs: 16 success, 1 failure ( Environment caveats, recorded as they are. Next. Enqueued at this tip; |
Written-by: Dev
Fixes #3219
Part of #3114
Owner: Dev
Reviewer: Reviewer
Tier: T2
Docs-not-needed: the waiting room keeps its layout, state and server calls; this cut lands thirteen zh dictionary entries and routes existing literals through the tr() at plugins/social/client.js:1018, so docs/subsystems/social.md and docs/subsystems/core-client.md describe structure that does not change.
Checkpoint
{ "pr": 3221, "claim": "Dev", "issue": 3219, "summary": "The Face-to-face waiting room now reads in the window's language. The dialog's waiting step and the room overview's candidate card draw their room number, QR hint, roster heading, alone line, Enter chat, Leave question and mine badges through the tr() the file already carries. Thirteen zh entries land and the two i18n baselines lose the nineteen pins those draws held; a window without a translator keeps today's English word for word.", "files": ["plugins/social/client.js", "core/src/client/i18n.js", "core/test/i18n-missing-entries.baseline.json", "core/test/i18n-template-draws.baseline.json", "plugins/social/test/face-waiting-room-i18n.test.js", "changelog.d/3219-face-waiting-room-zh.fixed.md", "plugins/social/test/sharing-page-i18n.test.js"], "checks": { "ran": "npm run verify (TZ=UTC)", "result": "green", "at": "c14d92499131d77d35b5d7bce608f9c65cfb0f31" }, "next": "none — ready for review" }What changed
A face-to-face waiting room follows the window's language. The dialog's
waitingstep and the room overview's candidate card now read 房间号码 / 房间号码 482913 / 房间号码 482913 的二维码 / 用 FlyBot 扫描加入 / 谁已加入 / 正在等其他人加入… / 进入聊天 / 离开这个房间? / 离开 / 留下 / 我的, and{name} (you)reuses its existing entry. Thirteen zh entries land aftercore/src/client/i18n.js:253, andi18n-missing-entries(132 → 115) andi18n-template-draws(27 → 25) lose the nineteen pins they carried;i18n-pluginsstays at 16.One line in cut 20's own test (
plugins/social/test/sharing-page-i18n.test.js:148) froze the baselines' absolute totals at 16 / 27 / 132, so any later cut that removes pins turns the social suite red. Cut 21 necessarily moves two of those totals, so that snapshot now names 16 / 25 / 115 — the cut-20 pins it guards are still asserted one by one above it. That is the seventh handwritten file, and the reason the hand-written total is 221 lines rather than the 215 in the slice spec.Verification at the tip
Tip SHA: c14d924
Ran:
cd plugins/social && TZ=UTC DSH_HARNESS=/opt/flybot node --import ./test/resolve.mjs --test test/face-waiting-room-i18n.test.js— 5/5/0 at this tip; the same file on a pristine5b32b96a5a44checkout with only the test added — 5/1/4 (cases 1, 2, 3 and 5 red, the English-fallback guard green on base);... --test test/social.test.js500/500/0;... --test test/face-rooms.test.js test/social-readonly.test.js55/55/0; the wholeplugins/socialsuite 728/728/0;cd core && node --test test/i18n-plugins.test.js test/i18n-template-draws.test.js test/i18n-missing-entries.test.js test/i18n-plugins-missing-zh.test.js test/i18n.test.js39/39/0;node core/scripts/build-client.mjs --check;node scripts/ds-bot-patches.mjs checkandcanonical(both ok,generate is a no-op);node .github/scripts/changelog.mjs check(16 fragments well formed);node .github/scripts/check-mojibake.mjs --check(0 occurrences in 1771 files);TZ=UTC npm run verifyexit 0 (arch-docs OK against a localorigin/mainref at the base).Not run: no real browser on this box, so nobody has looked at a Chinese waiting room in a window — the render is read from the component tree in the test instead. This cut covers only the waiting room and its number / QR: the setup and join steps, the invite cards and
FaceAutoSendkeep their baseline pins, and the rest of Social stays English in a Chinese window as before. The ordering with #3112 is not exercised: both cuts add zh keys only, and whichever merges second must keep both blocks and rerunbuild-client→generate→check→canonical. The box has noorigin/main(the work copy is a tarball), so arch-docs ran against a local ref at the base commit rather than the live remote.