Repository navigation
docs(site): replace the chat footer with a risk notice and add follow-ups - #1144
Merged
Merged
Conversation
The chat footer now says what a reader needs (third-party, model-generated, verify the source) instead of "MCP setup"; MCP lives behind the header info icon and the /deepwiki/ page. Follow-ups include the last two Q/A turns, the typing state can be stopped, failures can be retried, and the composer respects the mobile safe area.
Collaborator
|
Review (Birfy) Tip SHA: 4836063
|
GitHub Pages serves the docs under /agentdescent/, while CI and a local build serve them at /. The chat panel's header info link and footer "Caveats" link were root-absolute (/deepwiki/), so they 404 on Pages and no local run can see it. Take the site root from the loaded assets/deepwiki.js script instead and build <root>/deepwiki/ from it, so both links resolve under a subpath and at the root. Without a script element there is no safe base, so the two anchors are omitted rather than pointed at a literal that 404s. Only the link base changes: no credentials are added, and the escaping order in inline()/escapeHtml is untouched.
Collaborator
Author
|
Tip SHA: befe705 Ran:
Not run:
Non-blocking: the diff adds no changelog fragment, although Verdict: PASS |
Collaborator
|
Review (Birfy) Tip SHA: befe705
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1126 (follow-up to the merged #1127).
What changed
MCP setup. MCP setup belongs with the integration docs, so it moved behind the header info icon and the guide link.Caveats) now derive their base from the loaded script —new URL('../deepwiki/', SELF.src).href— instead of a root-absolutehref="/deepwiki/". GitHub Pages serves this site under/agentdescent/while a local build sits at/, so the root-absolute form rendered in CI and 404'd on Pages. With no script element there is no safe base, so both anchors are left out rather than pointed at a literal.env(safe-area-inset-bottom)and the log usesoverscroll-behavior: contain.docs/assets/deepwiki.js,docs/assets/deepwiki.cssand one site test change; no engine or page changes.Verification at the tip
Tip SHA: befe705
Red first, base
48360631with only the new test rows:1 failed, 2 passed—FAILED tests/test_site_navigation.py::test_deepwiki_links_derive_their_base_from_the_script_url.Ran:
pytest -q tests/test_site_navigation.pyat this tip ->3 passednode --check docs/assets/deepwiki.js-> passmkdocs build --clean --strict(social plugin excluded on this host: it needs cairo) -> pass, 12.17 spython tests/test_site_navigation.py site-> 148 rendered documentation pages passpython -m tools.gen_api_docs --check->docs/api.md is up to dateNot run:
docsworkflow runs both on this PRpytest -q— thetestsworkflow runs it on this PRgrep -c 'href="/deepwiki/"' docs/assets/deepwiki.js->0, andtest_deepwiki_links_derive_their_base_from_the_script_urlpins that plus bothanchors being built from
GUIDE.Screenshots
Before = built
main76223fda; after = built this tipbefe7053. Both buildsserved under a real
/agentdescent/subpath so the GitHub Pages layout isexercised, launcher clicked,
#dw-panelcaptured. Evidence branch:evidence/1144@974f8ffc.1440 px viewport
Before (1440 px) — the footer points at a root-absolute
/deepwiki/, which 404s under the Pages subpath:After (1440 px) — the same panel at this tip:
390 px viewport
Before (390 px):
After (390 px):
Capture notes: 1440 / 390 in the captions are the browser viewport widths, not
the image widths. The capture script sets
viewport={"width": width, "height": 900}with
device_scale_factorleft unset (devicePixelRatio= 1, so 1 CSS px = 1 image px)and then screenshots the
#dw-panelelement instead of the full viewport. Each imageis therefore a 1:1 crop of the panel at that viewport — 410 px wide at 1440, 360 px wide
at 390 (
width: min(410px, calc(100vw - 1.5rem))) — which is why the files are narrowerthan the viewport they were taken at. Nothing is resampled.
Measured in the same runs: before, the footer
hrefwas/deepwiki/→ 404under
/agentdescent/(the header link did not render at all); after, headerand footer both resolve to
…/agentdescent/deepwiki/→ 200, and under aroot serve both give
/deepwiki/→ 200.Merge to
maindeployshttps://thinkflowlab.github.io/agentdescent/.