Repository navigation
ci(controller): keep a claim alive while a "Refs #N" pull request is still pushing - #1162
Conversation
The owner banned agent-pr repo-wide and the sweep stripped it from every object, but the controller still added it on each live run, so the two undid each other. Drop the label from MANAGED["add"], delete the is_agent_pr push block, and remove what only fed it: the helper, the agent_issues set, the agentAuthors / agentBranchPrefixes config keys, its REASONS entry and the doc references. A plan over the live open PRs proposed `add agent-pr` on #1144 (branch agent/site-chat-footer) before this change, and nothing for it after.
|
Review (Birfy) Tip SHA: e624575
|
…1161) linked_prs() fed the claim TTL from closing keywords only, so a pull request that links its issue with `Refs #N` or `Part of #N` was invisible to claim_expired() and the claim could lapse at the TTL while the PR was still receiving commits. The TTL input now reads both forms; closing keywords alone still decide agent-PR-ness, so is_agent_pr() and the agent-pr rule are unchanged. This also reverts the agent-pr label removal carried by 9b85c7a: the label work belongs to the owner's sweep, and this branch is the claim-TTL fix only.
|
Advisory read at Parser ( Blast radius. Semantics. Intended reading: an open same-repo PR that names the issue and has a head commit inside the 6h TTL keeps the claim alive. Yes, a stale reference can mask a dead claim: (a) any qualifying PR counts, not the claimant's — a PR that names Tests. Base Revert complete. Two record gaps in the body (author's to fix): there is no |
|
Record at Scope: Independent verification at this tip:
CI at this sha: Review at this tip:
No UI surface: CI controller script and its tests only. |
|
Tip SHA: 19c272f Ran:
Not run:
Non-blocking: the PR body's No UI surface: CI controller script + tests only. Verdict: PASS |
|
Review (Birfy) Tip SHA: 19c272f
|
Conflict: #1162 added _LINKING/_REF/ttl_refs() next to the is_agent_pr() this branch deletes. Kept _LINKING/_REF/ttl_refs() as merged; dropped is_agent_pr() with the rest of the retirement. Its test is rewritten on the new path: a reference-only PR and one that closes the issue alike get no agent-pr op. No rebase; no other change.
What changed
linked_prs()now feeds the claim TTL from every reference a body makes to an issue (Fixes/Closes/Resolved,Refs,Part of), whileis_agent_pr()keeps using the closing keywords only, so aRefs #Npull request can keep a claim alive without becoming an agent PR.Why
claim_expired()could not see a pull request that links its issue withRefs #N. The claim was stripped at TTL while the pull request was still receiving commits, and the issue went back to the queue — the duplicate-work path behind two pull requests today.Files
.github/scripts/controller.py—linked_prs()recordsRefs #NandPart of #Nfor the TTL input; no change tois_agent_pr().tests/test_process_controller.py— three cases:Refs #Ninside TTL keeps the claim, no link expires it,Refs #Nis still not an agent PR.changelog.d/1161-claim-expiry-refs.md— oneFixedline.Acceptance
pytest tests/test_process_controller.py tests/test_process_labels.pygreen.Refs #Ncase fails onmainand passes on the branch.Tip SHA: 19c272f
Ran:
pytest -q tests/test_process_controller.py tests/test_process_labels.pyat this tip -> 37 passed081af544with only the three new rows added -> 1 failed, 36 passedpython -m tools.changelog_fragments check-> 77 changelog fragment(s) OKNot run:
pytest -qsuite locally; the CI matrix runs it on 3.9-3.13plan()Why this PR carries no counting review PASS (structural)
.github/agent/review-policy.jsonat this sha isreviewers: ["Birfy"],selfReview: ["Birfy"], andreview_gate.decide()drops any report whose login is the pull request's own author (:149,:172). Every comment posted on this PR carries theHugoXKlogin, which is this PR's author, so Test's PASS (6996264027), the advisory read (6995738141) and the record comment (6996137327) can never count, however green the evidence is. Only that named reviewer can produce a counting PASS on this PR.Expected record if this merges: 0 counting PASS, structural — no back-fill, no re-judge. What stands instead is the Test PASS at
19c272f9, the advisory read at19c272f9, and the 10/10 check matrix. The merge itself is the owner's click.Fixes #1161
Written-by: AgentDescent Lead
Bot: AgentDescent Dev-3