Repository navigation
Conversation
The owner banned `agent-pr` repo-wide and the sweep stripped it from every object, but the controller still added it back on each run, so the two kept undoing each other. Drop the add from MANAGED, its reason, the docstring line, and the `is_agent_pr` rule with the agent-author/branch-prefix heuristics that only it read. The two `controller.json` keys that fed those heuristics go with it; `labels.json` still defines the label (create-only sync, inert) and is left alone. Not a gate change: `review-gate.yml` has no label filter, so no check stops judging PRs either way.
|
Not reviewed at c0bcb11 yet, two things first:
|
Conflict: #1162 added _LINKING/_REF/ttl_refs() next to the is_agent_pr() this branch deletes. Kept _LINKING/_REF/ttl_refs() as merged; dropped is_agent_pr() with the rest of the retirement. Its test is rewritten on the new path: a reference-only PR and one that closes the issue alike get no agent-pr op. No rebase; no other change.
|
Merge resolution: Why: Semantics are otherwise identical to the original pull request: |
|
Owner decision: the |
|
Not mergeable on the current premise: at head |
Canonical candidate for the
agent-prretirement change, withmainmerged in at8aea052(merge commit, no rebase). No further commits while it is under review.Nothing here closes an issue:
#1161was closed as completed by#1162(76223fda), which is a different fix, and this body carries no closing keyword, so a merge here neither re-closes nor re-opens it.The owner banned
agent-prrepo-wide and the sweep stripped it from everyobject, but the controller still added it back on each run, so the two kept
undoing each other. This removes the add and the code that existed only to
decide it.
.github/scripts/controller.py:MANAGED["add"]isRISKonly, theagent-prreason is gone, and theis_agent_prrule (author allowlist,agent/branch prefix, "closes an agent issue") is deleted with theagent_issuesplumbing it was the only reader of. The docstring no longeradvertises the label.
.github/agent/controller.json: dropsagentAuthorsandagentBranchPrefixes, which nothing reads any more.AGENTS.md,.claude/skills/fix-issue/SKILL.md: the state-label list, thePR checklist and the controller description now say the label is retired
instead of telling agents to add it.
tests/test_process_controller.py: new rowtest_a_plan_never_adds_agent_pr_not_even_on_an_agent_branch(red on main),the ops assertion expects the risk label only, and one extra "bad plan" row
pins that
applyrefuses a hand-writtenagent-pradd.changelog.d/1161-controller-drop-agent-pr.md.labels.jsonstill defines the label and is untouched: the sync iscreate/update-only, so the definition is inert once nothing adds it.
Not a gate change:
review-gate.ymltriggers on pull-request events, not onlabels, so no check stops judging a PR either way.
Merge of
mainafter#1162#1162landedttl_refs()in the same part ofcontroller.pyone commit before this branch was reviewed, somain(76223fda) is merged in. One textual conflict, incontroller.py, resolved like this:main, unchanged:_LINKING,_REF,ttl_refs(), so theRefs #Nclaim-TTL fix stays exactly as merged andlinked_prs()still reads it.is_agent_pr(). Its test,test_a_refs_pull_request_is_still_not_an_agent_pr(added by#1162, it called that function), is rewritten rather than deleted:test_a_refs_pull_request_never_gets_the_agent_pr_labelnow asserts the same safety property on the surviving path — a PR whose body only references the issue, aPart ofbody and a closing body alike produce noagent-properation, andis_agent_pris gone rather than merely unused.#1162's other two claim-TTL rows are untouched.Scope: no change outside that conflict and that one test — historically named
#1161, which now belongs to the claim-TTL fix, so the references and the fragment filename are left as they were and the record question is tracked separately.Tip SHA: 8aea052
Ran:
f2eda2e7with only the new row applied:1 failed, 28 passedpytest tests/test_process_controller.py tests/test_process_labels.pyat this tip:38 passedpytest tests/test_controller.pyat this tip:11 passedpython3 -m tools.changelog_fragments check:80 changelog fragment(s) OKpytest tests/test_site_navigation.py tests/test_repo_hygiene.py:4 passedgrep -n "agent-pr" .github/scripts/controller.py .github/agent/controller.jsonreturns nothinggit diff --stat origin/main: 6 files,+58/-56;git diff --stat c0bcb116..HEAD: 6 files,+80/-18c0bcb116+76223fdaNot run:
mkdocs build --strict— no docs page or nav changed;AGENTS.mdand the skill file are not part of the sitemainat76223fdacarries the known 31 red node ids, and this diff touches only the controller and its test fileReview path
8aea052, one review request toBirfy, asked once and not repeated..github/agent/review-policy.jsonisreviewers: ["Birfy"],selfReview: ["Birfy"]. A report from this seat is dropped as self-review because the pull request's author login is the same one: measured with the repo's ownreview_gate.decide(), a seat PASS readscounts Falsewhile aBirfyPASS at the same tip readscounts True. ABirfyreport at this tip is the countable path..github/**is T3, so the merge needs an explicit owner click; thereview-gatestep is report-only and does not block it.Birfycould find. The code and the docs already follow it and no check depends on it, so a line from the owner settles it without another commit here.No UI surface: CI controller script, its config, tests and markdown files.