Repository navigation
docs(hosts): state the kept config roots as an exception to the env scrub - #1165
Merged
Merged
Conversation
…crub Closes #1098. The env-scrub note said it drops "every" session marker and then kept two of them: CLAUDE_CONFIG_DIR and XDG_CONFIG_HOME are literal SESSION_MARKERS entries and DETACHED_KEEP_VARS keeps them (plus CODEX_HOME/DSH_HOME, matched by the CODEX_/DSH_ prefixes). Both texts now name the four kept host config roots as an exception to the marker list before the wildcard list appears, so the first clause cannot be read as dropping them. docs/dsh-super-agent.md and changelog.d/1082-host-env-scrub.md only; one Fixed fragment for this change. No code, no test, no behaviour.
Collaborator
|
Review (Birfy) Tip SHA: d56c4f0
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1098
What changed
docs/dsh-super-agent.md:110-116and the#1082release note(
changelog.d/1082-host-env-scrub.md:2-12) said the scrub drops everysession marker and then, two lines later, that four config roots are kept — with
XDG_CONFIG_HOMEnamed in both halves, so the first clause read as dropping avariable the second one kept.
Both texts now state the exception in the first clause, over the marker list,
instead of after it:
The wildcards stay where they do the work — they are what enforces the drop for
CLAUDE*,DSH_*andCODEX*— but they no longer appear next to a "kept"clause without that explicit exception. New fragment
changelog.d/1098-env-scrub-exception.md(Fixed) records the correction.Before (main
f2eda2e)docs/dsh-super-agent.md:110-113:changelog.d/1082-host-env-scrub.md:2-5:After
Both files: the first clause names the four kept roots as the exception, then the
marker list follows. The page keeps the
DETACHED_KEEP_VARSconstant next tothe
SESSION_MARKERSname in the following sentence, so the two halves stayparallel. No other sentence changed meaning.
Reproduce
The last command returns the exception line in both files and no
drops every.Verification at the tip
Tip SHA: d56c4f0
Ran:
python3 -m tools.changelog_fragments check→78 changelog fragment(s) OKpython3 -m tools.gen_api_docs --check→docs/api.md is up to datepython3 -m pytest tests/test_site_navigation.py tests/test_repo_hygiene.py→4 passedNot run:
tests/test_docs_links.py—ModuleNotFoundError: No module named 'markdown'in this clonemkdocs build --strict— no mkdocs in this clone; CIbuildis the real lineScope
docs/dsh-super-agent.md+changelog.d/1082-host-env-scrub.md+ oneFixedfragment. No code, no test (the issue says none should be added), no
surface_common.py, no behaviour change.No UI surface: docs-only prose change, no code path touched; the page is
docs/dsh-super-agent.md(mkdocs nav: "dsh-super-agent — the zero-codecomposition"), rendered by CI
build.Written-by: AgentDescent Dev-4
Bot: AgentDescent Dev-4