Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions changelog.d/1082-host-env-scrub.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
Fixed
A detached run no longer inherits the worker's own session: `runstore.launch`
drops every `SESSION_MARKERS` variable -- `DSH_*`, `CLAUDE*`, `CODEX*`, `MCP_*`,
the OpenCode config carriers and `XDG_CONFIG_HOME` -- before it starts the
grandchild, so the host worker's session identity and MCP server configuration
stay with the host while the credentials and `PATH` the run needs still pass
through (#1082). The list is the one the candidate worker already dropped
drops the host-session markers it lists, except the four host config roots it
keeps (`CLAUDE_CONFIG_DIR`, `CODEX_HOME`, `DSH_HOME`, `XDG_CONFIG_HOME`), before
it starts the grandchild, so the host worker's session identity and MCP server
configuration stay with the host while the credentials and `PATH` the run needs
still pass through (#1082). The marker list is `SESSION_MARKERS` (`DSH_*`,
`CLAUDE*`, `CODEX*`, `MCP_*`, the OpenCode config carriers and
`XDG_CONFIG_HOME`), the one the candidate worker already dropped
(`agentdescent.agents.worker_env`); it used to be a second, shorter copy, and
five of its eleven entries crossed the scrub. The host's config/home
directories (`CLAUDE_CONFIG_DIR`, `CODEX_HOME`, `DSH_HOME`, `XDG_CONFIG_HOME`)
are kept, because they name configuration rather than session and the run
resolves a host's real home from them (#1082).
five of its eleven entries crossed the scrub. Those four roots name
configuration rather than session, and the run resolves a host's real home from
them (#1082).
6 changes: 6 additions & 0 deletions changelog.d/1098-env-scrub-exception.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Fixed
The env-scrub note no longer says it drops "every" session marker and then keeps
some of them: `docs/dsh-super-agent.md` and the #1082 release note now name the
four host config roots (`CLAUDE_CONFIG_DIR`, `CODEX_HOME`, `DSH_HOME`,
`XDG_CONFIG_HOME`) as an exception to the marker list before that list appears,
so the first clause cannot be read as dropping them (#1098).
17 changes: 9 additions & 8 deletions docs/dsh-super-agent.md
Original file line number Diff line number Diff line change
Expand Up @@ -108,14 +108,15 @@ your tree, under the operator's write allowlist).
the Ticket.
- `plan` is the budget line: it estimates cost without executing. Read it before
`start`, and put the number in the Ticket.
- A detached run no longer inherits the worker session: `launch` drops every
host-session marker (`SESSION_MARKERS`: `DSH_*`, `CLAUDE*`, `CODEX*`, `MCP_*`,
the OpenCode config carriers, `XDG_CONFIG_HOME`) before it starts the
grandchild, so the worker's session identity and MCP config stay with the
host while the API keys the run needs are passed through (`#1082`). The list
is the one the candidate worker drops, not a second copy of it. The host's
config/home directories (`DETACHED_KEEP_VARS`: `CLAUDE_CONFIG_DIR`,
`CODEX_HOME`, `DSH_HOME`, `XDG_CONFIG_HOME`) are kept: they name
- A detached run no longer inherits the worker session: `launch` drops the
host-session markers it lists, except the four host config roots it keeps
(`DETACHED_KEEP_VARS`: `CLAUDE_CONFIG_DIR`, `CODEX_HOME`, `DSH_HOME`,
`XDG_CONFIG_HOME`), before it starts the grandchild, so the worker's session
identity and MCP config stay with the host while the API keys the run needs
are passed through (`#1082`).
The marker list is `SESSION_MARKERS`: `DSH_*`, `CLAUDE*`, `CODEX*`, `MCP_*`,
the OpenCode config carriers and `XDG_CONFIG_HOME`; it is the one the
candidate worker drops, not a second copy of it. Those four roots name
configuration, not session, and this run resolves a host's real home from
them for `isolate: false` workers and for `agentdescent start` from a
terminal.
Expand Down
Loading