Repository navigation
Integrate disabled Discord safehouse routing and authenticated spool - #15
Conversation
valzargaming
left a comment
There was a problem hiding this comment.
Completed Codex source review of exact head b06ca16 against main 2a4ae45.
No blocking defect found in the reviewed disabled defaults/configuration migration, options-resolver coexistence, named-command reconciliation, private acknowledgement before effects, strict actor/request/confirmation boundaries, immutable spool, bounded replay/recovery and pending/unknown handling. Existing installations retain safehouse_enabled=false and no gateway without a configuration change. Scoped independent read-only source reviews were also completed during this closeout.
Verification: all 44 substantive exact-head check records are now completed/success; the publication job is skipped. Direct job steps confirmed Windows/Linux PHP 8.3–8.5 spool/economic-driver tests and PHP 8.3–8.5 dependency-backed Discord route/schema tests (https://github.com/Valgorithms/Civilizationbot/actions/runs/39832339402). Portable, local-profile, locked-dependency and heartbeat contracts also passed. The latest commit changes acceptance docs and the CI trigger; local whitespace checks passed. No new local suite was run for this review record.
Limits: this is a COMMENT recording the completed Codex source review, not an independent maintainer APPROVE event. It does not establish native/game compatibility, actual Discord registration/delivery, live linking/trades, connected raid/long-term recovery, host power-loss durability, activation or release acceptance. The fixed native checker covers inspect/link only; newer DTO evidence and installation-specific writer/key/clock/retention review remain gates in docs/safehouse-acceptance.md. No bot/game control, runtime checkout, credentials or production data changed.
Behavior
Adds disabled game-authoritative safehouse/trade routing, a pure command schema, private asynchronous Discord handling and an authenticated immutable spool. Explicit confirmation, actor/request binding, bounded recovery and named-command reconciliation preserve the authority and registration boundaries. Defaults remain
safehouse_enabled=falsewith no gateway; existing installations need no configuration migration to retain disabled behavior.Main
2a4ae459a05a4b71a5ce5d8a50505fec5d8acce7, including merged #20, is integrated. The options regression preserves directory/safehouse/portable defaults together without bot construction. Scoped independent review found no remaining merge-critical defect in the disabled source.Verification
Final source head:
b06ca166db3a4b9c3a9c7f0f8a31173b96d72979.Final source review and later activation
Completed exact-head Codex source review is recorded as a COMMENT review, with evidence and limits. This is not an independent maintainer APPROVE event. The normal merge completed as
821afe15822b5ecf5417210854970661394a0682.docs/safehouse-acceptance.mdrecords reviewed default/migration behavior, durability limits and bounded follow-up plans. Native compatibility and activation remain explicitly pending:These gates apply before the corresponding compatibility/activation claim, not before source review of disabled code. No game fixture generation, saves, live command registration, activation, bot/game control, deployment, credentials or real trade occurred.
CI reconciliation: the previously stuck job
120011420022is now completed/success. At exact headb06ca166db3a4b9c3a9c7f0f8a31173b96d72979, all 44 substantive check records are completed/success; the publication job is completed/skipped. The completed source review and normal merge are recorded above.