[rejaulalomkhan]

Description

test_attachment_attached_to_non_existent_post_type_has_a_pretty_permalink() removes not_a_post_type by unsetting it from $wp_post_types, which bypasses the cleanup in unregister_post_type().

• Replaces the manual unset with unregister_post_type( 'not_a_post_type' ).
• Removes the now-unused global $wp_post_types.

The test still covers an attachment whose parent's post type no longer exists.

Testing

vendor/bin/phpunit --filter 'Tests_Link::'
vendor/bin/phpunit -c tests/phpunit/multisite.xml --filter 'Tests_Link::'
vendor/bin/phpcs tests/phpunit/tests/link.php

All pass (7 tests, 28 assertions); PHPCS: no errors.

Trac ticket: https://core.trac.wordpress.org/ticket/65893

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Use of AI Tools

AI assistance: Yes
Tool(s): Google Antigravity (original change), Claude Code (review follow-up)
Model(s): claude-3-7-sonnet / gemini-2.5-pro (original change, as disclosed), Claude Opus 5.5
Used for: Finding the manual unset and replacing it, then narrowing the change after review. I reviewed every line and take responsibility for the change.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props rejaulalomkhan, lancewillett, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

---

Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

• @propsbot add <username> to give props to a GitHub user. Requires write access.
• @propsbot remove <username> to leave a user out of the props. Requires write access.
• @propsbot refresh to refresh this list. Adding the props-bot label works too.

[Copilot]

🟡 Changes recommended

The attachment test unsets not_a_post_type before teardown, causing cleanup to fail and leave post-type supports and rewrite registration behind.

1 open issue

• Use unregister_post_type before removing test post type · New

What changed in this PR

This PR adds teardown cleanup to WordPress’s link tests to improve isolation between tests that register custom post types.

Changes:

• Adds Tests_Link::tear_down() to unregister wptests_pt and not_a_post_type.
• Calls the parent teardown after the custom cleanup.

File	Description
tests/​phpunit/​tests/​link.php	Adds custom post-type cleanup to the link test teardown.

_{Review effort: Balanced}

[lancewillett]

One cleanup gap remains in the attachment test, as Copilot noted. I reproduced it in single-site and multisite: the existing manual unset removes the post-type object before teardown, leaving supports, the permastruct, and the rewrite tag behind. Replacing that unset loop with unregister_post_type() preserved the original assertions and removed the leaked state. Please make that change before landing.

_{AI review · gpt-6}

[lancewillett]

Please replace the manual $wp_post_types unset loop in test_attachment_attached_to_non_existent_post_type_has_a_pretty_permalink() with unregister_post_type( 'not_a_post_type' ) at the same point. The object is already gone when this teardown call runs, so it returns invalid_post_type and cannot remove the remaining supports and rewrite state. The replacement keeps the nonexistent-post-type scenario intact.

_{AI review · gpt-6}

[rejaulalomkhan]

@lancewillett Replaced the unset loop with unregister_post_type( 'not_a_post_type' ) and dropped the now-unused global $wp_post_types (bdc1d1b). Checked after teardown: the supports, permastruct and rewrite tag for not_a_post_type were left behind before, and are removed now. Tests_Link passes on single site, multisite and random order.

[lancewillett]

Please drop the broad tear_down() list and keep this focused on replacing the manual post-type unset with unregister_post_type(), including removal of the unused global. The shared per-test reset already unregisters surviving custom types. Raw registry removal is a distinct cleanup bypass, so retain that narrow correction for review. Residue probes do not establish a separate failing-test regression.

_{AI review · gpt-6}

[rejaulalomkhan]

@lancewillett Removed tear_down() in c0b038d. The PR now only replaces the manual $wp_post_types unset with unregister_post_type() and removes the unused global. Tests_Link passes on single site and multisite.

[Copilot]

🟢 Approval recommended

No active review issues were identified for the attachment permalink test cleanup change.

No open issues 🎉

1 resolved since last review

• Use unregister_post_type before removing test post type

_{Review effort: Balanced}

[lancewillett]

The narrowed change is supported. Removing the post type between the pretty and plain permalink assertions is part of the behavior being tested; the public unregistration API replaces the manual loop clearly. No broad teardown is needed.

The existing link class passes before and after in randomized single-site and multisite runs (7 tests, 28 assertions each). PHPCS, CI and the fresh Copilot review are clear. This is a simplification of the existing test, not a claim of a separately demonstrated downstream isolation failure.

_{AI review · gpt-6}

[lancewillett]

PR #14950 landed in https://core.trac.wordpress.org/changeset/65186