Skip to content

Tests: Replace the manual post type unset in link tests with unregister_post_type() #14950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rejaulalomkhan wants to merge 3 commits into from
Closed

Tests: Replace the manual post type unset in link tests with unregister_post_type() #14950

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a8d214
Tests: Unregister custom post types in link tests teardown
rejaulalomkhan Oct 27, 2026
bdc1d1b
Tests: Unregister not_a_post_type instead of unsetting it in the atta…
rejaulalomkhan Oct 31, 2026
c0b038d
Tests: Remove the broad tear_down() from Tests_Link.
rejaulalomkhan Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions tests/phpunit/tests/link.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,6 @@ public function test_unattached_attachment_has_a_pretty_permalink() {
* @ticket 1914
*/
public function test_attachment_attached_to_non_existent_post_type_has_a_pretty_permalink() {
global $wp_post_types;

$this->set_permalink_structure( '/%year%/%monthnum%/%day%/%postname%/' );

register_post_type( 'not_a_post_type', array( 'public' => true ) );
Expand All @@ -175,12 +173,7 @@ public function test_attachment_attached_to_non_existent_post_type_has_a_pretty_

$this->assertSame( get_permalink( $post_id ) . user_trailingslashit( $attachment->post_name ), get_permalink( $attachment_id ) );

foreach ( $wp_post_types as $id => $pt ) {
if ( 'not_a_post_type' === $pt->name ) {
unset( $wp_post_types[ $id ] );
break;
}
}
unregister_post_type( 'not_a_post_type' );

$this->assertSame( home_url( "/?attachment_id={$attachment->ID}" ), get_permalink( $attachment_id ) );
// Visit permalink.
Expand Down
Loading