[rejaulalomkhan]

Description

Makes the two data providers in tests/phpunit/tests/block-bindings/patternOverridesSource.php public static: data_empty_metadata_names() and data_override_values_and_types(). PHPUnit 10+ requires static data providers, and neither uses instance state.

Refreshed against trunk after r64987, which removed data_empty_context() and trimmed the other two providers. Their current datasets are unchanged, and test_get_value_returns_null_when_context_empty() stays without a provider.

Testing

vendor/bin/phpunit --filter Tests_Block_Bindings_Pattern_Overrides_Source
vendor/bin/phpunit -c tests/phpunit/multisite.xml --filter Tests_Block_Bindings_Pattern_Overrides_Source
vendor/bin/phpunit --filter Tests_Block_Bindings_Pattern_Overrides_Source --order-by=random --random-order-seed=12345
vendor/bin/phpcs tests/phpunit/tests/block-bindings/patternOverridesSource.php

All pass (13 tests, 16 assertions); PHPCS: no errors.

Trac ticket: https://core.trac.wordpress.org/ticket/66211

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Use of AI Tools

AI assistance: Yes
Tool(s): Google Antigravity (original change), Claude Code (review follow-up)
Model(s): Gemini 2.5 Pro, Claude Opus 5.5
Used for: Converting the providers, then merging trunk after r64987 and running the tests. I reviewed every line and take responsibility for the change.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props rejaulalomkhan, shailu25, mukesh27, lancewillett.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

---

Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

• @propsbot add <username> to give props to a GitHub user. Requires write access.
• @propsbot remove <username> to leave a user out of the props. Requires write access.
• @propsbot refresh to refresh this list. Adding the props-bot label works too.

[shail-mehta]

LGTM👍

Providers don't use instance state, so making them static looks correct.

As per Lance's note on #66211, Please group by directory (or ~6–8 files) for follow-ups instead of one PR per file.

[lancewillett]

Please refresh this against trunk. r64987 removed data_empty_context() and trimmed the other two providers, so the current patch no longer applies.

Keep that cleanup intact and make only the two surviving providers static: data_empty_metadata_names() and data_override_values_and_types(). Please preserve their current datasets and leave test_get_value_returns_null_when_context_empty() without a provider.

_{AI review · gpt-6}

[Copilot]

🟢 Approval recommended

No active review issues remain for the PHPUnit 10+ data-provider compatibility update.

No open issues 🎉

What changed in this PR

Updates the pattern overrides block bindings tests for PHPUnit 10+ compatibility by declaring all three affected data providers public static.

Changes:

• Converts data_empty_metadata_names(), data_empty_context(), and data_override_values_and_types() to static methods.
• Leaves test datasets and assertions unchanged.

File	Description
tests/​phpunit/​tests/​block-bindings/​patternOverridesSource.php	Makes three data providers static to meet PHPUnit 10+ requirements.

_{Review effort: Balanced}

[rejaulalomkhan]

@lancewillett Merged trunk (f86841c). The file now matches trunk apart from data_empty_metadata_names() and data_override_values_and_types() becoming static; the r64987 cleanup and datasets are unchanged, and test_get_value_returns_null_when_context_empty() has no provider.

[Copilot]

🟢 Approval recommended

No active review issues are reported for the PHPUnit data-provider compatibility update.

No open issues 🎉

_{Review effort: Balanced}

[lancewillett]

The refresh preserves the trunk cleanup and datasets; only the two surviving providers change to static.

Static checks passed. The affected classes passed together in randomized single-site and multisite runs: 408 tests and 1,383 assertions in each mode.

_{AI review · gpt-6}

[lancewillett]

PR #14970 landed in https://core.trac.wordpress.org/changeset/65128