Skip to content

Tests: Make pattern overrides block bindings data providers static #14970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rejaulalomkhan wants to merge 2 commits into from
Closed

Tests: Make pattern overrides block bindings data providers static #14970

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cbbc17
Tests: Make pattern overrides block bindings data providers static.
rejaulalomkhan Oct 27, 2026
f86841c
Merge remote-tracking branch 'upstream/trunk' into pr-14970-fix
rejaulalomkhan Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/phpunit/tests/block-bindings/patternOverridesSource.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public function test_get_value_returns_null_when_metadata_name_empty( array $att
*
* @return array[]
*/
public function data_empty_metadata_names() {
public static function data_empty_metadata_names() {
return array(
'empty attributes' => array( array() ),
'empty metadata array' => array( array( 'metadata' => array() ) ),
Expand Down Expand Up @@ -224,7 +224,7 @@ public function test_get_value_handles_different_data_types( $expected ) {
*
* @return array[]
*/
public function data_override_values_and_types() {
public static function data_override_values_and_types() {
return array(
'empty string' => array( '' ),
'zero integer' => array( 0 ),
Expand Down
Loading