Repository navigation
feat(observability): identify selected request resource revisions - #11
Draft
afourniernv wants to merge 1 commit into
Draft
afourniernv wants to merge 1 commit into
afourniernv wants to merge 1 commit into
Conversation
2 of 5 tasks
afourniernv
changed the base branch from
feat/5395-credential-correlation/afourniernv
to
codex/relay-state-01-correlation-primitives
November 10, 2026 23:04
afourniernv
changed the base branch from
codex/relay-state-01-correlation-primitives
to
feat/5395-credential-correlation/afourniernv
November 13, 2026 00:37
5 of 6 tasks
afourniernv
force-pushed
the
feat/5395-credential-correlation/afourniernv
branch
from
November 17, 2026 17:27
c0f634b to
8bc8f32
Compare
afourniernv
force-pushed
the
feat/5396-request-revisions/afourniernv
branch
from
November 17, 2026 17:27
720e766 to
486e90e
Compare
Signed-off-by: Alex Fournier <afournier@nvidia.com>
afourniernv
force-pushed
the
feat/5395-credential-correlation/afourniernv
branch
from
November 18, 2026 00:48
8bc8f32 to
7b3ab05
Compare
afourniernv
force-pushed
the
feat/5396-request-revisions/afourniernv
branch
from
November 18, 2026 00:48
486e90e to
4cdb38a
Compare
afourniernv
changed the base branch from
feat/5395-credential-correlation/afourniernv
to
main
November 18, 2026 00:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Identify the policy, endpoint and credential snapshot actually selected by an inspected request. This is independently based on main and #5214, without requiring the middleware or credential-observation follow-ups.
Related Issue
Closes NVIDIA#5396. Tracking: NVIDIA#5210.
Changes
Integration note: this and MCP #12 overlap at JSON-RPC scope creation. When combining them, capture policy generation and endpoint at the earlier scope creation, before body inspection. The combined build was tested with that resolution.
Release Notes
Request traces and security records identify the configuration selected for that request, not necessarily the configuration current when an operator investigates it. A selected credential snapshot does not establish injection or delivery.
Testing
Checks appropriate to the affected code and behavior pass
Unit tests added/updated (if applicable)
E2E tests added/updated (if applicable)
Independent network Nextest suite: 1,728 passed; seven skipped. All five focused snapshot tests passed.
The new regression completes request A, reloads policy, confirms the idle connection closes, reconnects for B, and checks both generations on request spans and correlated OCSF records.
Same-surviving-connection coverage depends on unmerged #5361; this PR does not implement or claim connection repinning.
Full independent and combined pre-commit checks, including strict Clippy, passed. Combined Nextest: 1,892 passed; seven skipped. Network Cargo tests with telemetry disabled: 1,731 passed; two ignored.
A fresh two-turn Hermes/Relay run verified changed loaded policy hash/generation across reload and reconnect, with matching request/root/OCSF identities. It does not claim surviving-connection or changed-enforcement coverage. These live cases use the combined follow-up build; the independent suite above qualifies this branch alone.
The broad workspace task is not green: an unchanged packaging assertion reproduces on pinned main, and a separate VM image-preparation test failed once then passed in isolation. Those files are outside this change.
Checklist