Repository navigation
feat(observability): trace bounded MCP inspection outcomes - #12
Draft
afourniernv wants to merge 1 commit into
Draft
afourniernv wants to merge 1 commit into
afourniernv wants to merge 1 commit into
Conversation
This was referenced Nov 9, 2026
afourniernv
force-pushed
the
feat/5396-request-revisions/afourniernv
branch
from
November 17, 2026 17:27
720e766 to
486e90e
Compare
afourniernv
force-pushed
the
feat/5397-mcp-correlation/afourniernv
branch
from
November 17, 2026 17:27
d0f6e48 to
745d8e1
Compare
Signed-off-by: Alex Fournier <afournier@nvidia.com>
afourniernv
force-pushed
the
feat/5397-mcp-correlation/afourniernv
branch
from
November 18, 2026 00:48
745d8e1 to
185d4d6
Compare
afourniernv
force-pushed
the
feat/5396-request-revisions/afourniernv
branch
from
November 18, 2026 00:48
486e90e to
4cdb38a
Compare
afourniernv
changed the base branch from
feat/5396-request-revisions/afourniernv
to
main
November 18, 2026 00:48
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Trace actual JSON-RPC/MCP inspection passes under the inspected HTTP request. This is independently based on main and #5214, not on resource revision tracing.
Related Issue
Closes NVIDIA#5397. Tracking: NVIDIA#5210.
Changes
No new external Rust API, protobuf field, configuration or enforcement capability.
Integration note: when combining with revisions #11, retain policy-generation and endpoint capture at this change's earlier JSON-RPC scope creation, before body inspection. The combined build was tested with that resolution.
Release Notes
An inspected request can show which JSON-RPC/MCP inspection passes ran and whether they accepted or rejected its shape. An accepted inspection can still be denied by policy; it does not prove a tool executed.
Testing
Checks appropriate to the affected code and behavior pass
Unit tests added/updated (if applicable)
E2E tests added/updated (if applicable)
Independent network Nextest suite: 1,725 passed; seven skipped.
Tests check bounded batch metadata, privacy, correct request parentage, malformed-input 400, valid-inspection/policy-denial 403, and correlation without exported spans.
Full independent and combined pre-commit checks, including strict Clippy, passed. Combined Nextest: 1,892 passed; seven skipped. Network Cargo tests with telemetry disabled: 1,731 passed; two ignored.
Fresh Hermes/Relay execution verified accepted MCP operations and an inspected-but-policy-denied rotation, with the target rotation counter unchanged. These live cases use the combined follow-up build; the independent suite above qualifies this branch alone.
The broad workspace task is not green: an unchanged packaging assertion reproduces on pinned main, and a separate VM image-preparation test failed once then passed in isolation. Those files are outside this change.
Checklist