Repository navigation
feat(observability): trace remote HTTP middleware RPCs - #9
Draft
afourniernv wants to merge 1 commit into
Draft
afourniernv wants to merge 1 commit into
afourniernv wants to merge 1 commit into
Conversation
This was referenced Nov 9, 2026
afourniernv
force-pushed
the
codex/relay-state-01-correlation-primitives
branch
2 times, most recently
from
November 16, 2026 01:13
11030e5 to
0f92636
Compare
afourniernv
force-pushed
the
feat/5394-middleware-correlation/afourniernv
branch
from
November 17, 2026 17:27
9501490 to
fbac941
Compare
afourniernv
changed the base branch from
codex/relay-state-01-correlation-primitives
to
main
November 17, 2026 17:28
Signed-off-by: Alex Fournier <afournier@nvidia.com>
afourniernv
force-pushed
the
feat/5394-middleware-correlation/afourniernv
branch
from
November 18, 2026 00:48
fbac941 to
b23f552
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Trace remote HTTP middleware RPCs beneath the supervisor's existing middleware stages. This is independently based on main, which already contains HTTP correlation core #5214.
Related Issue
Closes NVIDIA#5394. Tracking: NVIDIA#5210.
Changes
No new external Rust API, protobuf field or configuration. This does not depend on the other correlation follow-ups.
Release Notes
Remote HTTP middleware calls can be followed from the supervisor's middleware stage into a service that exports compatible traces.
Testing
Checks appropriate to the affected code and behavior pass
Unit tests added/updated (if applicable)
E2E tests added/updated (if applicable)
Independent middleware Nextest suite: 157 passed.
Tests cover context replacement, rotating bearer preservation, stream lifetime, refusal versus transport failure, and excluding sensitive fields.
Full independent and combined pre-commit checks, including strict Clippy, passed. Combined Nextest: 1,892 passed; seven skipped. Network Cargo tests with telemetry disabled: 1,731 passed; two ignored.
Fresh Hermes/Relay execution verified request/response redaction, guard refusal and recovery, with real RPC children. A successful refusal RPC remains distinct from HTTP admission. These live cases use the combined follow-up build; the independent suite above qualifies this branch alone.
The broad workspace task is not green: an unchanged packaging assertion reproduces on pinned main, and a separate VM image-preparation test failed once then passed in isolation. Those files are outside this change.
Checklist