Skip to content

feat(observability): describe credential preparation outcomes - #10

Draft
afourniernv wants to merge 1 commit into
mainfrom
feat/5395-credential-correlation/afourniernv
Draft

afourniernv wants to merge 1 commit into
mainfrom
feat/5395-credential-correlation/afourniernv

Conversation

@afourniernv

@afourniernv afourniernv commented Nov 9, 2026 •

Copy link
Copy Markdown
Owner

Summary

Add bounded preparation details to existing credential stages so operators can distinguish resolution/signing results from later forwarding failures. This is independently based on main, including #5214, not on middleware RPC tracing.

Related Issue

Closes NVIDIA#5395. Tracking: NVIDIA#5210.

Changes

  • Observe actual static header/body substitution, Basic authentication, SigV4 signing and token-grant preparation.
  • Record bounded mechanism, placement and preparation outcomes, including not-needed, refusal, failure and staleness.
  • Keep preparation separate from transmission: a configured resolver or stripped header does not imply credential use; prepared does not prove upstream receipt.
  • Preserve credential custody, policy ordering, endpoint/placement restrictions and existing OCSF emissions. Export no credential values or exchange bodies.

No new external Rust API, protobuf field or configuration. A policy stop before preparation does not create a new withholding event.

Release Notes

Credential stages explain how preparation finished without treating successful preparation as proof that a request was delivered.

Testing

  • Checks appropriate to the affected code and behavior pass

  • Unit tests added/updated (if applicable)

  • E2E tests added/updated (if applicable)

  • Independent network Nextest suite: 1,723 passed; seven skipped.

  • Updated tests check successful/refused token grants, Basic/static rewriting, signing versus upstream failure, and excluding secrets from spans.

  • Full independent and combined pre-commit checks, including strict Clippy, passed. Combined Nextest: 1,892 passed; seven skipped. Network Cargo tests with telemetry disabled: 1,731 passed; two ignored.

  • Fresh Hermes/Relay execution verified protected REST, MCP and real read-only GitHub /user credential preparation. Uncredentialed desk requests report not_needed; credential values are not exported. These live cases use the combined follow-up build; the independent suite above qualifies this branch alone.

  • The broad workspace task is not green: an unchanged packaging assertion reproduces on pinned main, and a separate VM image-preparation test failed once then passed in isolation. Those files are outside this change.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable): crate and published trace guidance updated; subsystem boundaries unchanged.

@afourniernv
afourniernv force-pushed the feat/5394-middleware-correlation/afourniernv branch from 9501490 to fbac941 Compare November 17, 2026 17:27
@afourniernv
afourniernv force-pushed the feat/5395-credential-correlation/afourniernv branch from c0f634b to 8bc8f32 Compare November 17, 2026 17:27
@afourniernv afourniernv changed the title feat(observability): correlate credential preparation and withholding feat(observability): describe credential preparation outcomes Nov 17, 2026
Signed-off-by: Alex Fournier <afournier@nvidia.com>
@afourniernv
afourniernv force-pushed the feat/5394-middleware-correlation/afourniernv branch from fbac941 to b23f552 Compare November 18, 2026 00:48
@afourniernv
afourniernv force-pushed the feat/5395-credential-correlation/afourniernv branch from 8bc8f32 to 7b3ab05 Compare November 18, 2026 00:48
@afourniernv
afourniernv changed the base branch from feat/5394-middleware-correlation/afourniernv to main November 18, 2026 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(observability): describe credential preparation outcomes

1 participant