Repository navigation
feat(observability): describe credential preparation outcomes - #10
Draft
afourniernv wants to merge 1 commit into
Draft
afourniernv wants to merge 1 commit into
afourniernv wants to merge 1 commit into
Conversation
This was referenced Nov 9, 2026
afourniernv
force-pushed
the
feat/5394-middleware-correlation/afourniernv
branch
from
November 17, 2026 17:27
9501490 to
fbac941
Compare
afourniernv
force-pushed
the
feat/5395-credential-correlation/afourniernv
branch
from
November 17, 2026 17:27
c0f634b to
8bc8f32
Compare
Signed-off-by: Alex Fournier <afournier@nvidia.com>
afourniernv
force-pushed
the
feat/5394-middleware-correlation/afourniernv
branch
from
November 18, 2026 00:48
fbac941 to
b23f552
Compare
afourniernv
force-pushed
the
feat/5395-credential-correlation/afourniernv
branch
from
November 18, 2026 00:48
8bc8f32 to
7b3ab05
Compare
afourniernv
changed the base branch from
feat/5394-middleware-correlation/afourniernv
to
main
November 18, 2026 00:48
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add bounded preparation details to existing credential stages so operators can distinguish resolution/signing results from later forwarding failures. This is independently based on main, including #5214, not on middleware RPC tracing.
Related Issue
Closes NVIDIA#5395. Tracking: NVIDIA#5210.
Changes
prepareddoes not prove upstream receipt.No new external Rust API, protobuf field or configuration. A policy stop before preparation does not create a new withholding event.
Release Notes
Credential stages explain how preparation finished without treating successful preparation as proof that a request was delivered.
Testing
Checks appropriate to the affected code and behavior pass
Unit tests added/updated (if applicable)
E2E tests added/updated (if applicable)
Independent network Nextest suite: 1,723 passed; seven skipped.
Updated tests check successful/refused token grants, Basic/static rewriting, signing versus upstream failure, and excluding secrets from spans.
Full independent and combined pre-commit checks, including strict Clippy, passed. Combined Nextest: 1,892 passed; seven skipped. Network Cargo tests with telemetry disabled: 1,731 passed; two ignored.
Fresh Hermes/Relay execution verified protected REST, MCP and real read-only GitHub
/usercredential preparation. Uncredentialed desk requests reportnot_needed; credential values are not exported. These live cases use the combined follow-up build; the independent suite above qualifies this branch alone.The broad workspace task is not green: an unchanged packaging assertion reproduces on pinned main, and a separate VM image-preparation test failed once then passed in isolation. Those files are outside this change.
Checklist